Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 305693002: Revert 273188 "Revert 271207 "Changed android toolchain to use G..." (Closed)

Created:
6 years, 6 months ago by Michael van Ouwerkerk
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Andrew Hayden (chromium.org)
Visibility:
Public.

Description

Revert 273188 "Revert 271207 "Changed android toolchain to use G..." In the time between upgrading from GCC 4.6 to 4.8 the codebase changed to trigger a compiler bug that exists in 4.6 but not in 4.8. We now have two options: fix our code for 4.6 or fix WebRTC. We need to upgrade to 4.8 either way. As the WebRTC team seems to have a potential fix for running on 4.8, we will go up to 4.8 again. > Revert 271207 "Changed android toolchain to use GCC 4.8" > > > Changed android toolchain to use GCC 4.8 > > > > BUG=359106 > > > > Review URL: https://codereview.chromium.org/218633007 > > TBR=fdegans@chromium.org > > Review URL: https://codereview.chromium.org/303493006 TBR=henrika@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -17 lines) Patch
M trunk/src/build/common.gypi View 8 chunks +21 lines, -12 lines 0 comments Download
M trunk/src/build/config/android/config.gni View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/build/config/arm.gni View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/build/config/compiler/BUILD.gn View 3 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael van Ouwerkerk
6 years, 6 months ago (2014-05-28 15:32:51 UTC) #1
Michael van Ouwerkerk
Committed patchset #1 manually as r273247.
6 years, 6 months ago (2014-05-28 15:33:02 UTC) #2
Andrew Hayden (chromium.org)
6 years, 6 months ago (2014-05-28 15:57:08 UTC) #3
Message was sent while issue was closed.
Bug: https://code.google.com/p/chromium/issues/detail?id=378349

Powered by Google App Engine
This is Rietveld 408576698