Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Issue 218633007: Changed android toolchain to use GCC 4.8 (Closed)

Created:
6 years, 8 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 7 months ago
Reviewers:
pasko, brettw, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Changed android toolchain to use GCC 4.8 BUG=359106 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271207

Patch Set 1 #

Patch Set 2 : Added gn changes. Put cflags in the proper section. #

Patch Set 3 : Fixed cflags. #

Patch Set 4 : rebase #

Patch Set 5 : clang fix #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase #

Patch Set 10 : Rebase #

Patch Set 11 : Rebase #

Patch Set 12 : Fix for gn build #

Total comments: 2

Patch Set 13 : Extra blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -17 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 11 8 chunks +21 lines, -12 lines 0 comments Download
M build/config/android/config.gni View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M build/config/arm.gni View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +23 lines, -3 lines 0 comments Download
A build/config/gcc/gcc_version.gni View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Fabrice (no longer in Chrome)
Hi all, This is to (finally) land GCC 4.8 on Android. I am not sure ...
6 years, 7 months ago (2014-05-15 16:51:13 UTC) #1
Nico
Hooray! Looks like you need to put "-Wno-unused-local-typedefs" in some gn file (probably uild/config/compiler/BUILD.gn). With ...
6 years, 7 months ago (2014-05-16 00:06:31 UTC) #2
Fabrice (no longer in Chrome)
Okay, I think that fixed it. I also added our new Android-specific flags to gn. ...
6 years, 7 months ago (2014-05-16 11:46:32 UTC) #3
pasko
LGTM++ with .gn* reviewed by brettw@
6 years, 7 months ago (2014-05-16 14:01:59 UTC) #4
brettw
Sweet, thanks for updating the GN build. LGTM https://codereview.chromium.org/218633007/diff/200001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/218633007/diff/200001/build/config/compiler/BUILD.gn#newcode218 build/config/compiler/BUILD.gn:218: Got ...
6 years, 7 months ago (2014-05-16 16:54:21 UTC) #5
Fabrice (no longer in Chrome)
Thanks, looks like we're good to go! https://codereview.chromium.org/218633007/diff/200001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/218633007/diff/200001/build/config/compiler/BUILD.gn#newcode218 build/config/compiler/BUILD.gn:218: On 2014/05/16 ...
6 years, 7 months ago (2014-05-16 17:08:24 UTC) #6
Fabrice (no longer in Chrome)
The CQ bit was checked by fdegans@chromium.org
6 years, 7 months ago (2014-05-16 17:08:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fdegans@chromium.org/218633007/220001
6 years, 7 months ago (2014-05-16 17:09:04 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 21:18:28 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 15:41:57 UTC) #10
Message was sent while issue was closed.
Change committed as 271207

Powered by Google App Engine
This is Rietveld 408576698