Issue 303493006: Revert 271207 "Changed android toolchain to use GCC 4.8"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303493006: Revert 271207 "Changed android toolchain to use GCC 4.8" (Closed)

Created:
6 years, 7 months ago by henrika (OOO until Aug 14)

Modified:
6 years, 7 months ago

Reviewers:
Andrew Hayden (chromium.org), Fabrice (no longer in Chrome)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 271207 "Changed android toolchain to use GCC 4.8" > Changed android toolchain to use GCC 4.8 > > BUG=359106 > > Review URL: https://codereview.chromium.org/218633007 TBR=fdegans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273188

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -45 lines)			Patch
M	trunk/src/build/common.gypi	View	8 chunks	+12 lines, -21 lines	0 comments	Download
M	trunk/src/build/config/android/config.gni	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/build/config/arm.gni	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/build/config/compiler/BUILD.gn	View	3 chunks	+3 lines, -22 lines	0 comments	Download

Total messages: 3 (0 generated)

henrika (OOO until Aug 14)

Committed patchset #1 manually as r273188 (tree was closed).

6 years, 7 months ago (2014-05-28 09:52:29 UTC) #2

Andrew Hayden (chromium.org)

6 years, 7 months ago (2014-05-28 10:41:52 UTC) #3

Message was sent while issue was closed.

The BUG= was missing for this review. For posterity:

https://code.google.com/p/chromium/issues/detail?id=376848

(Thanks, henrika@)