Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 305293002: Add GN build file for ui/aura target. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
jamesr, brettw, scottmg
CC:
ben+aura_chromium.org, brettw, chromium-reviews, cjhopman, Dirk Pranke, kalyank, sadrul, tdresser+watch_chromium.org
Visibility:
Public.

Description

Add GN build file for ui/aura target. Test plan: Debug: $ gn gen out/Debug_gn $ ninja -C out/Debug_gn aura Release: $ gn gen out/Release_gn --args='is_debug=false' $ ninja -C out/Release_gn aura Android: $ gn gen out/Debug_gn --args='os="android" cpu_arch="arm"' $ ninja -C out/Debug_gn aura BUG=None TEST=see above. R=brettw@chromium.org,scottmg@chromium.org TBR=ben NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275607

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : GL fix #

Patch Set 4 : rebase #

Patch Set 5 : revert ui/gl change + exclude from android #

Total comments: 4

Patch Set 6 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -10 lines) Patch
M BUILD.gn View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M build/config/linux/BUILD.gn View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A ui/aura/BUILD.gn View 1 1 chunk +302 lines, -0 lines 0 comments Download
M ui/events/platform/BUILD.gn View 1 2 3 4 5 2 chunks +11 lines, -9 lines 0 comments Download
A ui/events/platform/x11/BUILD.gn View 1 chunk +42 lines, -0 lines 0 comments Download
A ui/gfx/x/BUILD.gn View 1 chunk +32 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (0 generated)
tfarina
Brett, I think this ready for review. Pending some gpu issues on Android: ../../gpu/config/gpu_info_collector_x11.cc:7:22: fatal ...
6 years, 6 months ago (2014-05-31 18:53:34 UTC) #1
tfarina
Brett, one issue remain. FAILED: ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/ui/gl/android/gl.scoped_java_surface.o.d -DGL_IMPLEMENTATION -DGL_GLEXT_PROTOTYPES -DEGL_EGLEXT_PROTOTYPES -DCHROMIUM_BUILD -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 ...
6 years, 6 months ago (2014-06-01 18:45:30 UTC) #2
tfarina
It maybe due to (the lack of) surface_jni_headers. Chris, have we ported build/jar_file_jni_generator.gypi to GN?
6 years, 6 months ago (2014-06-01 18:47:57 UTC) #3
cjhopman
On 2014/06/01 18:47:57, tfarina wrote: > It maybe due to (the lack of) surface_jni_headers. > ...
6 years, 6 months ago (2014-06-02 18:33:35 UTC) #4
tfarina
Scott, could you do the review instead? I think Brett is busy with Blink.
6 years, 6 months ago (2014-06-07 00:39:13 UTC) #5
scottmg
lgtm https://codereview.chromium.org/305293002/diff/100001/ui/aura/BUILD.gn File ui/aura/BUILD.gn (right): https://codereview.chromium.org/305293002/diff/100001/ui/aura/BUILD.gn#newcode111 ui/aura/BUILD.gn:111: "//build/config/linux:xrandr", is :xi necessary here (as compared with ...
6 years, 6 months ago (2014-06-07 01:52:38 UTC) #6
tfarina
https://codereview.chromium.org/305293002/diff/100001/ui/aura/BUILD.gn File ui/aura/BUILD.gn (right): https://codereview.chromium.org/305293002/diff/100001/ui/aura/BUILD.gn#newcode111 ui/aura/BUILD.gn:111: "//build/config/linux:xrandr", On 2014/06/07 01:52:38, scottmg wrote: > is :xi ...
6 years, 6 months ago (2014-06-07 02:38:45 UTC) #7
brettw
LGTM, sorry again.
6 years, 6 months ago (2014-06-07 02:49:31 UTC) #8
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-07 04:04:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/305293002/120001
6 years, 6 months ago (2014-06-07 04:04:33 UTC) #10
commit-bot: I haz the power
Change committed as 275607
6 years, 6 months ago (2014-06-07 04:09:38 UTC) #11
jamesr
https://codereview.chromium.org/305293002/diff/120001/ui/gfx/x/BUILD.gn File ui/gfx/x/BUILD.gn (right): https://codereview.chromium.org/305293002/diff/120001/ui/gfx/x/BUILD.gn#newcode6 ui/gfx/x/BUILD.gn:6: output_name = "gfx_x11" hmm, there's been a ui/gfx/BUILD.gn:gfx_x11 target ...
6 years, 6 months ago (2014-06-21 00:41:10 UTC) #12
brettw
https://codereview.chromium.org/305293002/diff/120001/ui/gfx/x/BUILD.gn File ui/gfx/x/BUILD.gn (right): https://codereview.chromium.org/305293002/diff/120001/ui/gfx/x/BUILD.gn#newcode6 ui/gfx/x/BUILD.gn:6: output_name = "gfx_x11" On 2014/06/21 00:41:09, jamesr wrote: > ...
6 years, 6 months ago (2014-06-21 00:46:35 UTC) #13
jamesr
6 years, 6 months ago (2014-06-21 00:51:15 UTC) #14
Message was sent while issue was closed.
On 2014/06/21 00:46:35, brettw wrote:
> https://codereview.chromium.org/305293002/diff/120001/ui/gfx/x/BUILD.gn
> File ui/gfx/x/BUILD.gn (right):
> 
>
https://codereview.chromium.org/305293002/diff/120001/ui/gfx/x/BUILD.gn#newcode6
> ui/gfx/x/BUILD.gn:6: output_name = "gfx_x11"
> On 2014/06/21 00:41:09, jamesr wrote:
> > hmm, there's been a ui/gfx/BUILD.gn:gfx_x11 target for a while now. which do
> we
> > want?
> 
> I think this one is better. We should always be having BUILD files closer to
the
> files.

ok, https://codereview.chromium.org/334633010/

Powered by Google App Engine
This is Rietveld 408576698