Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 294323002: Add generate_jar_jni template (Closed)

Created:
6 years, 7 months ago by cjhopman
Modified:
6 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, tfarina
Visibility:
Public.

Description

Add generate_jar_jni template This implements jar_file_jni_generator.gypi for GN. Also, add the //ui/gl:surface_jni_headers and enable some targets that depend on it. BUG=359249 R=brettw@chromium.org,tfarina@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275222

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase (+fix specified output file) #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -20 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M base/android/jni_generator/jni_generator.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/config.gni View 1 chunk +5 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 3 3 chunks +110 lines, -11 lines 0 comments Download
M ui/gl/BUILD.gn View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M ui/snapshot/BUILD.gn View 1 2 3 1 chunk +4 lines, -0 lines 3 comments Download

Messages

Total messages: 21 (0 generated)
cjhopman
brettw: *
6 years, 6 months ago (2014-06-03 01:31:28 UTC) #1
cjhopman
brettw: *
6 years, 6 months ago (2014-06-03 01:31:29 UTC) #2
brettw
Whoops, sorry. I looked at this a while ago and thought I was done, but ...
6 years, 6 months ago (2014-06-04 20:02:03 UTC) #3
brettw
Still forgot... LGTM
6 years, 6 months ago (2014-06-04 20:02:11 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-04 21:02:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/294323002/60001
6 years, 6 months ago (2014-06-04 21:05:20 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 22:48:31 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 22:53:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/192033) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71706) linux_chromium_chromeos_rel ...
6 years, 6 months ago (2014-06-04 22:53:11 UTC) #9
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-04 23:08:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/294323002/80001
6 years, 6 months ago (2014-06-04 23:09:06 UTC) #11
cjhopman
https://codereview.chromium.org/294323002/diff/80001/ui/snapshot/BUILD.gn File ui/snapshot/BUILD.gn (right): https://codereview.chromium.org/294323002/diff/80001/ui/snapshot/BUILD.gn#newcode49 ui/snapshot/BUILD.gn:49: sources -= [ I don't know that this is ...
6 years, 6 months ago (2014-06-04 23:10:11 UTC) #12
tfarina
https://codereview.chromium.org/294323002/diff/80001/ui/snapshot/BUILD.gn File ui/snapshot/BUILD.gn (right): https://codereview.chromium.org/294323002/diff/80001/ui/snapshot/BUILD.gn#newcode49 ui/snapshot/BUILD.gn:49: sources -= [ On 2014/06/04 23:10:12, cjhopman wrote: > ...
6 years, 6 months ago (2014-06-05 02:12:26 UTC) #13
brettw
https://codereview.chromium.org/294323002/diff/80001/ui/snapshot/BUILD.gn File ui/snapshot/BUILD.gn (right): https://codereview.chromium.org/294323002/diff/80001/ui/snapshot/BUILD.gn#newcode49 ui/snapshot/BUILD.gn:49: sources -= [ Yeah, this is what I have ...
6 years, 6 months ago (2014-06-05 02:38:15 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 03:17:52 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 03:22:42 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71762)
6 years, 6 months ago (2014-06-05 03:22:42 UTC) #17
tfarina
TBRing Ben for ui/ changes.
6 years, 6 months ago (2014-06-05 18:28:07 UTC) #18
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-05 18:28:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/294323002/80001
6 years, 6 months ago (2014-06-05 18:29:39 UTC) #20
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 19:47:33 UTC) #21
Message was sent while issue was closed.
Change committed as 275222

Powered by Google App Engine
This is Rietveld 408576698