[SyncFS] Add TaskLog tab on chrome://syncfs-internals

[SyncFS] Add TaskLog tab on chrome://syncfs-internals

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274285

[tzik, 2014-05-30 10:02:11]

PTL

[peria, 2014-06-02 02:37:15]

https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/sync_file_system_internals/task_log.html (right):

https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
chrome/browser/resources/sync_file_system_internals/task_log.html:5: <thead>
Could you remove <thead> tag?
This is an optional guide, but I think using <thead> is not so general.
http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=Op...

https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/sync_file_system_internals/task_log.js (right):

https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
chrome/browser/resources/sync_file_system_internals/task_log.js:23:
tr.appendChild(createElementFromText(
Could you move these "tr.appendChild" lines to #45?
I think those 4 additions should be on consecutive lines, not to miss one.

[tzik, 2014-06-02 05:17:01]

https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/sync_file_system_internals/task_log.html (right):

https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
chrome/browser/resources/sync_file_system_internals/task_log.html:5: <thead>
On 2014/06/02 02:37:16, peria wrote:
> Could you remove <thead> tag?
> This is an optional guide, but I think using <thead> is not so general.
>
http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=Op...

Done.

https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
File chrome/browser/resources/sync_file_system_internals/task_log.js (right):

https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
chrome/browser/resources/sync_file_system_internals/task_log.js:23:
tr.appendChild(createElementFromText(
On 2014/06/02 02:37:16, peria wrote:
> Could you move these "tr.appendChild" lines to #45?
> I think those 4 additions should be on consecutive lines, not to miss one.

Done.

[peria, 2014-06-02 05:32:56]

On 2014/06/02 05:17:01, tzik wrote:
>
https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
> File chrome/browser/resources/sync_file_system_internals/task_log.html
(right):
> 
>
https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
> chrome/browser/resources/sync_file_system_internals/task_log.html:5: <thead>
> On 2014/06/02 02:37:16, peria wrote:
> > Could you remove <thead> tag?
> > This is an optional guide, but I think using <thead> is not so general.
> >
>
http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=Op...
> 
> Done.
> 
>
https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
> File chrome/browser/resources/sync_file_system_internals/task_log.js (right):
> 
>
https://codereview.chromium.org/304993004/diff/20001/chrome/browser/resources...
> chrome/browser/resources/sync_file_system_internals/task_log.js:23:
> tr.appendChild(createElementFromText(
> On 2014/06/02 02:37:16, peria wrote:
> > Could you move these "tr.appendChild" lines to #45?
> > I think those 4 additions should be on consecutive lines, not to miss one.
> 
> Done.
Thank you for your works.
However, the patch set 4 looks to modify so many files dirty.
Please talk with me more proactively if you think my comment brings wrong
styles.

[tzik, 2014-06-02 05:46:30]

Done

[peria, 2014-06-02 05:47:09]

lgtm

[tzik, 2014-06-02 08:17:18]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-06-02 08:17:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/304993004/90001

[commit-bot: I haz the power, 2014-06-02 18:18:30]

Change committed as 274285