chrome/browser/resources/sync_file_system_internals/task_log.html - Issue 304993004: [SyncFS] Add TaskLog tab on chrome://syncfs-internals

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/sync_file_system_internals/task_log.html

Issue 304993004: [SyncFS] Add TaskLog tab on chrome://syncfs-internals (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <script src="chrome://syncfs-internals/task_log.js"></script>

	2

	3 <h3>Task Log</h3>

	4 <table>

	5 <thead>
	peria 2014/06/02 02:37:16 Could you remove <thead> tag? This is an optional Could you remove <thead> tag? This is an optional guide, but I think using <thead> is not so general. http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=Op... tzik 2014/06/02 05:17:02 Done. Show quoted text On 2014/06/02 02:37:16, peria wrote: > Could you remove <thead> tag? > This is an optional guide, but I think using <thead> is not so general. > http://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=Op... Done.
	6 <tr>

	7 <td class="task-log-duration">Duration</td>

	8 <td class="task-log-description">Task</td>

	9 <td class="task-log-result">Result</td>

	10 <td class="task-log-result">Details</td>

	11 </tr>

	12 </thead>

	13 <tbody id="task-log-entries"></tbody>

	14 </table>

OLD	NEW