Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Unified Diff: chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

Issue 304993004: [SyncFS] Add TaskLog tab on chrome://syncfs-internals (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
diff --git a/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc b/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
index e778f8ee8f87a0a36dbe50eb124ad59e90e11195..a14132c1c1502cc1e44e2a1d3da45b2855063950 100644
--- a/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
+++ b/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
@@ -102,7 +102,7 @@ void SyncFileSystemInternalsHandler::OnLogRecorded(
scoped_ptr<base::ListValue> details(new base::ListValue);
details->AppendStrings(task_log.details);
dict.Set("details", details.release());
- web_ui()->CallJavascriptFunction("SyncService.onTaskLogRecorded", dict);
+ web_ui()->CallJavascriptFunction("TaskLog.onTaskLogRecorded", dict);
}
void SyncFileSystemInternalsHandler::GetServiceStatus(
@@ -174,11 +174,12 @@ void SyncFileSystemInternalsHandler::ObserveTaskLog(
if (!observing_task_log_) {
observing_task_log_ = true;
sync_service->task_logger()->AddObserver(this);
- return;
}
+ DCHECK(sync_service->task_logger());
const sync_file_system::TaskLogger::LogList& log =
sync_service->task_logger()->GetLog();
+
for (sync_file_system::TaskLogger::LogList::const_iterator itr = log.begin();
itr != log.end(); ++itr)
OnLogRecorded(**itr);

Powered by Google App Engine
This is Rietveld 408576698