Issue 304943002: Bench rebaseline from codereview: fix is_finished

Issue 304943002: Bench rebaseline from codereview: fix is_finished (Closed)

Created:
6 years, 6 months ago by borenet

Modified:
6 years, 6 months ago

Reviewers:
epoger, benchen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Bench rebaseline from codereview: fix is_finished TBR=epoger,benchen BUG=skia:2225 NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14962

Patch Set 2 : remove pritn #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	tools/gen_bench_expectations_from_codereview.py	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

borenet

https://codereview.chromium.org/304943002/diff/1/tools/gen_bench_expectations_from_codereview.py File tools/gen_bench_expectations_from_codereview.py (right): https://codereview.chromium.org/304943002/diff/1/tools/gen_bench_expectations_from_codereview.py#newcode43 tools/gen_bench_expectations_from_codereview.py:43: print data Will remove this before submitting.

6 years, 6 months ago (2014-05-29 15:43:46 UTC) #1

borenet

Committing TBR to unblock myself. Will address comments in a later CL.

6 years, 6 months ago (2014-05-29 15:58:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/304943002/20001

6 years, 6 months ago (2014-05-29 15:59:25 UTC) #6

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages