Bench rebaseline from codereview: fix is_finished

tools/gen_bench_expectations_from_codereview.py

 #!/usr/bin/python
 
 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """Generate new bench expectations from results of trybots on a code review."""
 
 
@@ skipping 22 matching lines @@
   Args:
     codereview_url: URL of the codereview in question.
 
   Returns:
       List of NamedTuples: (builder_name, build_number, is_finished)
   """
   results = compare_codereview.CodeReviewHTMLParser().parse(codereview_url)
   try_builds = []
   for builder, data in results.iteritems():
     if builder.startswith('Perf'):
+      print data

[borenet, 2014/05/29 15:43:47]

Will remove this before submitting.

       build_num = data.url.split('/')[-1] if data.url else None
-      try_builds.append(TryBuild(builder, build_num,
-                                 data.status != 'pending'))
+      is_finished = (data.status not in ('pending', 'try-pending') and
+                     build_num is not None)
+      try_builds.append(TryBuild(builder_name=builder,
+                                 build_number=build_num,
+                                 is_finished=is_finished))
   return try_builds
 
 
 def _all_trybots_finished(try_builds):
   """Return True iff all of the given try jobs have finished.
 
   Args:
       try_builds: list of TryBuild instances.
 
   Returns:
@@ skipping 115 matching lines @@
   if failed_gen_expectations:
     failure += 'Failed to generate expectations for: %s\n\n' % ','.join(
         failed_gen_expectations)
   if failure:
     raise Exception(failure)
 
 
 if __name__ == '__main__':
   gen_bench_expectations_from_codereview(sys.argv[1])