Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/gen_bench_expectations_from_codereview.py

Issue 304943002: Bench rebaseline from codereview: fix is_finished (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: remove pritn Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gen_bench_expectations_from_codereview.py
diff --git a/tools/gen_bench_expectations_from_codereview.py b/tools/gen_bench_expectations_from_codereview.py
index f29c6526f57a25ea00bc29a01d728fc85ebd1908..3d40aa67eb04d3dd4d87a40305e9ebd4ec648c5c 100644
--- a/tools/gen_bench_expectations_from_codereview.py
+++ b/tools/gen_bench_expectations_from_codereview.py
@@ -41,8 +41,11 @@ def find_all_builds(codereview_url):
for builder, data in results.iteritems():
if builder.startswith('Perf'):
build_num = data.url.split('/')[-1] if data.url else None
- try_builds.append(TryBuild(builder, build_num,
- data.status != 'pending'))
+ is_finished = (data.status not in ('pending', 'try-pending') and
+ build_num is not None)
+ try_builds.append(TryBuild(builder_name=builder,
+ build_number=build_num,
+ is_finished=is_finished))
return try_builds
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698