Issue 304773003: Add support for GetByExtensionId

Issue 304773003: Add support for GetByExtensionId (Closed)

Created:
6 years, 6 months ago by achuithb

Modified:
6 years, 6 months ago

Reviewers:
tonyg, zel

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add support for GetByExtensionId This is necessary for testing apps that are not installed using --load-extension. GetByExtensionId returns a list of extensions as each extension may have a number of related contexts for its various windows and background page. BUG=378408 TEST=testExtensionGetByExtensionId and testWebApp Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273510

Patch Set 1 #

Patch Set 2 : support for multiple extension contexts #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -27 lines)			Patch
M	tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py	View	1	1 chunk	+20 lines, -19 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/chrome/extension_backend.py	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/extension_dict.py	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/extension_unittest.py	View	1	3 chunks	+36 lines, -5 lines	0 comments	Download
A +	tools/telemetry/unittest_data/simple_app/background.js	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	tools/telemetry/unittest_data/simple_app/main.html	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	tools/telemetry/unittest_data/simple_app/manifest.json	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	tools/telemetry/unittest_data/simple_app/second.html	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/304773003/1

6 years, 6 months ago (2014-05-28 19:52:46 UTC) #3

achuithb

Please take another look, Tony and Zel. GetByExtensionId now returns a list of inspectable contexts ...

6 years, 6 months ago (2014-05-28 23:17:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/304773003/40001

6 years, 6 months ago (2014-05-29 00:58:16 UTC) #7

Message was sent while issue was closed.

Change committed as 273510

Expand Messages | Collapse Messages