Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/extension_backend.py

Issue 304773003: Add support for GetByExtensionId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: support for multiple extension contexts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/extension_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/extension_backend.py b/tools/telemetry/telemetry/core/backends/chrome/extension_backend.py
index bdf9d00071a3bf79b978a448d17a15b4d50e2cef..a48088738cf02cf1f5a44c2629440c26a95ba58b 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/extension_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/extension_backend.py
@@ -26,10 +26,13 @@ class ExtensionBackendDict(collections.Mapping):
self._extension_backend_list = ExtensionBackendList(browser_backend)
def __getitem__(self, extension_id):
+ extensions = []
for i, context_id in enumerate(self._extension_backend_list):
if self.ContextIdToExtensionId(context_id) == extension_id:
- return self._extension_backend_list[i]
- raise KeyError('Cannot find an extension with id=%s' % extension_id)
+ extensions.append(self._extension_backend_list[i])
+ if not extensions:
+ raise KeyError('Cannot find an extension with id=%s' % extension_id)
+ return extensions
def __iter__(self):
for context_id in self._extension_backend_list:

Powered by Google App Engine
This is Rietveld 408576698