Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: tools/telemetry/telemetry/core/extension_dict.py

Issue 304773003: Add support for GetByExtensionId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: support for multiple extension contexts Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/extension_dict.py
diff --git a/tools/telemetry/telemetry/core/extension_dict.py b/tools/telemetry/telemetry/core/extension_dict.py
index c4659c75dc6a722b622506054b396f60513657d3..53e2d328d972f48b277bc235ffc4da954131da94 100644
--- a/tools/telemetry/telemetry/core/extension_dict.py
+++ b/tools/telemetry/telemetry/core/extension_dict.py
@@ -16,7 +16,7 @@ class ExtensionDict(object):
ExtensionPage instance."""
if not isinstance(load_extension, extension_to_load.ExtensionToLoad):
raise TypeError("Input param must be of type ExtensionToLoad")
- return self._extension_backend[load_extension.extension_id]
+ return self.GetByExtensionId(load_extension.extension_id)[0]
def __contains__(self, load_extension):
"""Checks if this ExtensionToLoad instance has been loaded"""
@@ -26,3 +26,8 @@ class ExtensionDict(object):
def keys(self):
return self._extension_backend.keys()
+
+ def GetByExtensionId(self, extension_id):
+ """Returns a list of extensions given an extension id. This is useful for
+ connecting to built-in apps and component extensions."""
+ return self._extension_backend[extension_id]

Powered by Google App Engine
This is Rietveld 408576698