chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc - Issue 304763002: Trust the renderer's same-document navigation flag if it is a same-origin nav.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

Issue 304763002: Trust the renderer's same-document navigation flag if it is a same-origin nav. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: isNavigationInPage->isFragmentNavigation, with caveat on the name Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/active_script_controller_unittest.cc ('k') | chrome/browser/translate/translate_manager_render_view_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

index 4ca541579f018a2790cea890aa08f6fc7d0ee320..57d805034673633385c45716dd8c7f4909169fb5 100644

--- a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

+++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc

@@ -291,7 +291,7 @@ TEST_F(GeolocationPermissionContextTests, GeolocationEnabledDisabled) {

base::string16 text_0 = infobar_delegate_0->GetButtonLabel(

ConfirmInfoBarDelegate::BUTTON_OK);

- NavigateAndCommit(requesting_frame);

+ Reload();

MockGoogleLocationSettingsHelper::SetLocationStatus(true, false);

EXPECT_EQ(0U, infobar_service()->infobar_count());

RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);

@@ -303,7 +303,7 @@ TEST_F(GeolocationPermissionContextTests, GeolocationEnabledDisabled) {

ConfirmInfoBarDelegate::BUTTON_OK);

EXPECT_NE(text_0, text_1);

- NavigateAndCommit(requesting_frame);

+ Reload();

MockGoogleLocationSettingsHelper::SetLocationStatus(false, false);

EXPECT_EQ(0U, infobar_service()->infobar_count());

RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);