chrome/browser/extensions/active_script_controller_unittest.cc - Issue 304763002: Trust the renderer's same-document navigation flag if it is a same-origin nav.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_script_controller_unittest.cc

Issue 304763002: Trust the renderer's same-document navigation flag if it is a same-origin nav. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: isNavigationInPage->isFragmentNavigation, with caveat on the name Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContentsClient.java ('k') | chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/active_script_controller_unittest.cc

diff --git a/chrome/browser/extensions/active_script_controller_unittest.cc b/chrome/browser/extensions/active_script_controller_unittest.cc

index a670a53fed45783e2f0b3d8462a57a83011ecc13..0b40328c14329891aeb22953d731e3e46710b495 100644

--- a/chrome/browser/extensions/active_script_controller_unittest.cc

+++ b/chrome/browser/extensions/active_script_controller_unittest.cc

@@ -219,9 +219,9 @@ TEST_F(ActiveScriptControllerUnitTest, PendingInjectionsRemovedAtNavigation) {

EXPECT_TRUE(controller()->GetActionForExtension(extension));

EXPECT_EQ(0u, GetExecutionCountForExtension(extension->id()));

- // Navigate away. This should remove the pending injection, and we should not

+ // Reload. This should remove the pending injection, and we should not

// execute anything.

- NavigateAndCommit(GURL("https://www.google.com"));

+ Reload();

EXPECT_FALSE(controller()->GetActionForExtension(extension));

EXPECT_EQ(0u, GetExecutionCountForExtension(extension->id()));

@@ -281,7 +281,7 @@ TEST_F(ActiveScriptControllerUnitTest, ActiveScriptsUseActiveTabPermissions) {

EXPECT_FALSE(controller()->RequiresUserConsentForScriptInjection(extension));

// Also test that granting active tab runs any pending tasks.

- NavigateAndCommit(GURL("https://www.google.com"));

+ Reload();

// Navigating should mean we need permission again.

EXPECT_TRUE(controller()->RequiresUserConsentForScriptInjection(extension));