chrome/browser/translate/translate_manager_render_view_host_unittest.cc - Issue 304763002: Trust the renderer's same-document navigation flag if it is a same-origin nav.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

Issue 304763002: Trust the renderer's same-document navigation flag if it is a same-origin nav. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: isNavigationInPage->isFragmentNavigation, with caveat on the name Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc ('k') | content/browser/android/web_contents_observer_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

diff --git a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

index 8e9d444ea07c79a27d492ad6c2bac8964d47c7f3..fadcd1b1e374e73824855111ffb3993f40400c81 100644

--- a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

+++ b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

@@ -94,7 +94,10 @@ class TranslateManagerRenderViewHostTest

void SimulateNavigation(const GURL& url,

const std::string& lang,

bool page_translatable) {

- NavigateAndCommit(url);

+ if (rvh()->GetMainFrame()->GetLastCommittedURL() == url)

+ Reload();

+ else

+ NavigateAndCommit(url);

SimulateOnTranslateLanguageDetermined(lang, page_translatable);

}

@@ -794,7 +797,8 @@ TEST_F(TranslateManagerRenderViewHostTest, ReloadFromLocationBar) {

NavEntryCommittedObserver nav_observer(web_contents());

web_contents()->GetController().LoadURL(

url, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());

- rvh_tester()->SendNavigate(0, url);

+ rvh_tester()->SendNavigateWithTransition(

+ 0, url, content::PAGE_TRANSITION_TYPED);

// Test that we are really getting a same page navigation, the test would be

// useless if it was not the case.