Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 304393002: Adds uploading picture benchmark JSON data (Closed)

Created:
6 years, 6 months ago by kelvinly
Modified:
6 years, 6 months ago
Reviewers:
rmistry, benchen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

Adds uploading picture benchmark JSON data BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/a3f08be531ef07ae4bf725cd6c0abd8dfc14b209

Patch Set 1 #

Total comments: 15

Patch Set 2 : Style improvements #

Total comments: 2

Patch Set 3 : Final style fixes #

Patch Set 4 : Fix broken upload code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -10 lines) Patch
M slave/skia_slave_scripts/bench_pictures.py View 2 chunks +11 lines, -2 lines 0 comments Download
M slave/skia_slave_scripts/run_bench.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M slave/skia_slave_scripts/upload_bench_results.py View 1 2 4 chunks +121 lines, -7 lines 0 comments Download
M slave/skia_slave_scripts/utils/sync_bucket_subdir.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kelvinly
Combines all the picture bench data into a single JSON file, which is then uploaded ...
6 years, 6 months ago (2014-05-29 21:06:40 UTC) #1
benchen
https://codereview.chromium.org/304393002/diff/1/slave/skia_slave_scripts/run_bench.py File slave/skia_slave_scripts/run_bench.py (right): https://codereview.chromium.org/304393002/diff/1/slave/skia_slave_scripts/run_bench.py#newcode13 slave/skia_slave_scripts/run_bench.py:13: from utils import misc # Looks like this is ...
6 years, 6 months ago (2014-05-29 22:20:09 UTC) #2
kelvinly
Fixed style problems https://codereview.chromium.org/304393002/diff/1/slave/skia_slave_scripts/run_bench.py File slave/skia_slave_scripts/run_bench.py (right): https://codereview.chromium.org/304393002/diff/1/slave/skia_slave_scripts/run_bench.py#newcode13 slave/skia_slave_scripts/run_bench.py:13: from utils import misc # Looks ...
6 years, 6 months ago (2014-05-30 00:44:51 UTC) #3
benchen
LGTM with minor suggestions. https://codereview.chromium.org/304393002/diff/1/slave/skia_slave_scripts/upload_bench_results.py File slave/skia_slave_scripts/upload_bench_results.py (right): https://codereview.chromium.org/304393002/diff/1/slave/skia_slave_scripts/upload_bench_results.py#newcode38 slave/skia_slave_scripts/upload_bench_results.py:38: # bench_entry: [<Bench_BmpConfig_TimeType>,<Platform-Alg>] Just that ...
6 years, 6 months ago (2014-05-30 00:57:23 UTC) #4
kelvinly
Will commit now https://codereview.chromium.org/304393002/diff/1/slave/skia_slave_scripts/upload_bench_results.py File slave/skia_slave_scripts/upload_bench_results.py (right): https://codereview.chromium.org/304393002/diff/1/slave/skia_slave_scripts/upload_bench_results.py#newcode38 slave/skia_slave_scripts/upload_bench_results.py:38: # bench_entry: [<Bench_BmpConfig_TimeType>,<Platform-Alg>] On 2014/05/30 00:57:23, ...
6 years, 6 months ago (2014-05-30 02:15:31 UTC) #5
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 6 months ago (2014-05-30 02:15:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/304393002/40001
6 years, 6 months ago (2014-05-30 02:16:42 UTC) #7
commit-bot: I haz the power
Change committed as a3f08be531ef07ae4bf725cd6c0abd8dfc14b209
6 years, 6 months ago (2014-05-30 02:16:58 UTC) #8
epoger
6 years, 6 months ago (2014-05-30 14:25:41 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/311433002/ by epoger@google.com.

The reason for reverting is: http://skbug.com/2628 ('UploadBenchResults failing
on all Perf-* bots').

Powered by Google App Engine
This is Rietveld 408576698