Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: slave/skia_slave_scripts/bench_pictures.py

Issue 304393002: Adds uploading picture benchmark JSON data (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Fix broken upload code Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | slave/skia_slave_scripts/run_bench.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: slave/skia_slave_scripts/bench_pictures.py
diff --git a/slave/skia_slave_scripts/bench_pictures.py b/slave/skia_slave_scripts/bench_pictures.py
index 451cdd50408ec7f94c382ad56448d0b324a87a64..e8ffd7710e7ce106229c0a0df1db7b3c82b95097 100644
--- a/slave/skia_slave_scripts/bench_pictures.py
+++ b/slave/skia_slave_scripts/bench_pictures.py
@@ -5,11 +5,13 @@
""" Run the Skia bench_pictures executable. """
-from build_step import BuildStep
-from run_bench import BenchArgs
import os
import sys
+from build_step import BuildStep
+from run_bench import BenchArgs
+from utils import gclient_utils
+
BENCH_REPEAT_COUNT = 10
@@ -28,10 +30,17 @@ class BenchPictures(BuildStep):
filename.replace('-', '').replace(':', '-'))
return full_path
+ def _BuildJSONDataFile(self, args):
+ git_timestamp = gclient_utils.GetGitRepoPOSIXTimestamp()
+ return '{}_{}.json'.format(
+ self._BuildDataFile(args),
+ git_timestamp)
+
def _DoBenchPictures(self, args):
arguments = ['-r', self._device_dirs.SKPDir()] + args
if self._perf_data_dir:
arguments.extend(BenchArgs(data_file=self._BuildDataFile(args)))
+ arguments.extend(['--jsonLog', self._BuildJSONDataFile(args)])
# For bench_pictures we use the --repeat and --logPerIter flags so that we
# can compensate for noisy performance.
arguments.extend(['--repeat', str(BENCH_REPEAT_COUNT), '--logPerIter'])
« no previous file with comments | « no previous file | slave/skia_slave_scripts/run_bench.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698