Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 304283007: Revert of Port most uses of SkOnce to SkLazyPtr. (Closed)

Created:
6 years, 6 months ago by mtklein
Modified:
6 years, 6 months ago
Reviewers:
mtklein_C, reed1
CC:
skia-review_googlegroups.com, bsalomon, robertphillips, tfarina
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org/304383005/) Reason for revert: Leaking refs on SkTypeface on Macs. Original issue's description: > Port most uses of SkOnce to SkLazyPtr. > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=15006 TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=15009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -98 lines) Patch
M include/core/SkPathRef.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypeface.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/ports/SkFontMgr.h View 1 chunk +1 line, -1 line 0 comments Download
M include/ports/SkFontMgr_indirect.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/ports/SkRemotableFontMgr.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFontHost.cpp View 2 chunks +11 lines, -6 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M src/core/SkLazyPtr.h View 3 chunks +3 lines, -5 lines 0 comments Download
M src/core/SkMatrix.cpp View 2 chunks +19 lines, -23 lines 0 comments Download
M src/core/SkMessageBus.h View 4 chunks +12 lines, -9 lines 0 comments Download
M src/core/SkPathRef.cpp View 2 chunks +10 lines, -8 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +27 lines, -11 lines 0 comments Download
M src/fonts/SkRemotableFontMgr.cpp View 2 chunks +11 lines, -5 lines 0 comments Download
M src/lazy/SkDiscardableMemoryPool.cpp View 2 chunks +16 lines, -9 lines 0 comments Download
M src/ports/SkFontConfigInterface_direct.cpp View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Port most uses of SkOnce to SkLazyPtr.
6 years, 6 months ago (2014-05-30 20:59:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/304283007/1
6 years, 6 months ago (2014-05-30 21:00:38 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 21:00:57 UTC) #3
Message was sent while issue was closed.
Change committed as 15009

Powered by Google App Engine
This is Rietveld 408576698