Port most uses of SkOnce to SkLazyPtr.

Port most uses of SkOnce to SkLazyPtr.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=15006

Committed: http://code.google.com/p/skia/source/detail?r=15014

Committed: https://skia.googlesource.com/skia/+/78358bf624c7e7c09ffccf638c50870808d884d6

[mtklein, 2014-05-29 23:42:53]

The follow-up where we port over most of SkOnce.

[tfarina, 2014-05-30 04:38:48]

Mike, I'm copying Brian and Robert for the unnamed conversion you did below and
where I commented in.

Cheers,

https://codereview.chromium.org/304383005/diff/40001/src/core/SkGlyphCache.cpp
File src/core/SkGlyphCache.cpp (right):

https://codereview.chromium.org/304383005/diff/40001/src/core/SkGlyphCache.cp...
src/core/SkGlyphCache.cpp:24: namespace {
Mike, could you keep the function static?

Brian and Robert long time ago gave me a "project" to convert unnamed namespace
to static.

I will finish it at some point, I just don't have spare time right now.

You can search the logs for it.

[mtklein, 2014-05-30 13:07:52]

https://codereview.chromium.org/304383005/diff/40001/src/core/SkGlyphCache.cpp
File src/core/SkGlyphCache.cpp (right):

https://codereview.chromium.org/304383005/diff/40001/src/core/SkGlyphCache.cp...
src/core/SkGlyphCache.cpp:24: namespace {
On 2014/05/30 04:38:48, tfarina wrote:
> Mike, could you keep the function static?

Nope.  You can't pass functions with static linkage as template parameters until
C++11.  Unfortunately this means any static Create or Destroy functions we want
to pass to SK_DECLARE_STATIC_LAZY_PTR need to be converted to non-static
functions in an anonymous namespace.

[tfarina, 2014-05-30 15:06:09]

https://codereview.chromium.org/304383005/diff/40001/src/core/SkGlyphCache.cpp
File src/core/SkGlyphCache.cpp (right):

https://codereview.chromium.org/304383005/diff/40001/src/core/SkGlyphCache.cp...
src/core/SkGlyphCache.cpp:24: namespace {
On 2014/05/30 13:07:53, mtklein wrote:
> On 2014/05/30 04:38:48, tfarina wrote:
> > Mike, could you keep the function static?
> 
> Nope.  You can't pass functions with static linkage as template parameters
until
> C++11.  Unfortunately this means any static Create or Destroy functions we
want
> to pass to SK_DECLARE_STATIC_LAZY_PTR need to be converted to non-static
> functions in an anonymous namespace.

OK. So it is inevitable.

I have had a problem like when doing the conversion too.

[reed1, 2014-05-30 20:09:24]

lgtm

https://codereview.chromium.org/304383005/diff/40001/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/304383005/diff/40001/include/core/SkTypeface....
include/core/SkTypeface.h:342: static SkTypeface* CreateDefault(int style);
add comment why we pass int instead of Style

[mtklein, 2014-05-30 20:12:05]

https://codereview.chromium.org/304383005/diff/40001/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.chromium.org/304383005/diff/40001/include/core/SkTypeface....
include/core/SkTypeface.h:342: static SkTypeface* CreateDefault(int style);
On 2014/05/30 20:09:25, reed1 wrote:
> add comment why we pass int instead of Style

Done.

[mtklein, 2014-05-30 20:12:10]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-05-30 20:13:25]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/304383005/60001

[commit-bot: I haz the power, 2014-05-30 20:42:05]

Change committed as 15006

[mtklein, 2014-05-30 20:59:41]

A revert of this CL has been created in
https://codereview.chromium.org/304283007/ by mtklein@google.com.

The reason for reverting is: Leaking refs on SkTypeface on Macs..

[mtklein, 2014-05-30 23:51:06]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-05-30 23:53:47]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/304383005/90001

[commit-bot: I haz the power, 2014-05-30 23:59:32]

Change committed as 15014

[mtklein, 2014-05-31 00:12:18]

A revert of this CL has been created in
https://codereview.chromium.org/306063004/ by mtklein@google.com.

The reason for reverting is: linux x86-64 release segfault in
src/ports/SkFontHost_fontconfig.cpp:107

http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Re....

[mtklein, 2014-06-02 15:39:56]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-06-02 15:40:15]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/304383005/130001

[commit-bot: I haz the power, 2014-06-02 15:44:30]

Change committed as 78358bf624c7e7c09ffccf638c50870808d884d6