Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: src/core/SkLazyPtr.h

Issue 304283007: Revert of Port most uses of SkOnce to SkLazyPtr. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkGlyphCache.cpp ('k') | src/core/SkMatrix.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkLazyPtr.h
diff --git a/src/core/SkLazyPtr.h b/src/core/SkLazyPtr.h
index 28bb895b76ceaa77e5e8b0e0989517a7b5a0a19e..515086876c636bf99fdecacb6db15649ae0429ee 100644
--- a/src/core/SkLazyPtr.h
+++ b/src/core/SkLazyPtr.h
@@ -62,7 +62,7 @@
#include "SkThread.h"
#include "SkThreadPriv.h"
-// See FIXMEs below.
+// See FIXME below.
class SkFontConfigInterface;
class SkTypeface;
@@ -100,6 +100,7 @@
#ifdef SK_DEBUG
// FIXME: We know we leak refs on some classes. For now, let them leak.
void cleanup(SkFontConfigInterface*) {}
+ void cleanup(SkTypeface*) {}
template <typename U> void cleanup(U* ptr) { Destroy(ptr); }
~SkLazyPtr() {
@@ -125,12 +126,9 @@
}
#ifdef SK_DEBUG
- // FIXME: We know we leak refs on some classes. For now, let them leak.
- void cleanup(SkTypeface*) {}
- template <typename U> void cleanup(U* ptr) { Destroy(ptr); }
~SkLazyPtrArray() {
for (int i = 0; i < N; i++) {
- this->cleanup((T*)fArray[i]);
+ Destroy((T*)fArray[i]);
fArray[i] = NULL;
}
}
« no previous file with comments | « src/core/SkGlyphCache.cpp ('k') | src/core/SkMatrix.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698