Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 304103002: Remove unnecessary members for tricky lazy initialization in AudioContext. (Closed)

Created:
6 years, 6 months ago by KhNo
Modified:
6 years, 6 months ago
Reviewers:
Raymond Toy
CC:
blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unnecessary members for tricky lazy initialization in AudioContext. The lazy initialization required the way to check wheather audio thread is finished or not to avoid lazy initialization by creation of other node after context uninitialzation. A m_audioThreadFinished is not needed anymore since initialization() will be called only once in construct. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175130

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -56 lines) Patch
M Source/modules/webaudio/AudioContext.h View 4 chunks +1 line, -7 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 12 chunks +29 lines, -48 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
KhNo
Please review. :)
6 years, 6 months ago (2014-05-29 15:00:09 UTC) #1
Raymond Toy
lgtm. But can you run a test before committing this? In AudioNode.h, set DEBUG_AUDIONODE_REFERNCES to ...
6 years, 6 months ago (2014-05-29 23:29:01 UTC) #2
KhNo
On 2014/05/29 23:29:01, Raymond Toy wrote: > lgtm. > > But can you run a ...
6 years, 6 months ago (2014-05-30 08:09:36 UTC) #3
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 6 months ago (2014-05-30 08:09:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/304103002/90001
6 years, 6 months ago (2014-05-30 08:10:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 13:19:18 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 14:05:58 UTC) #7
Message was sent while issue was closed.
Change committed as 175130

Powered by Google App Engine
This is Rietveld 408576698