Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: Source/modules/webaudio/AudioContext.h

Issue 304103002: Remove unnecessary members for tricky lazy initialization in AudioContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/webaudio/AudioContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/AudioContext.h
diff --git a/Source/modules/webaudio/AudioContext.h b/Source/modules/webaudio/AudioContext.h
index 69b88a9fb105eb48ffd3907f46aaad8038ead43f..d6c9f8b94dd35250a394af0793db2307a907b594 100644
--- a/Source/modules/webaudio/AudioContext.h
+++ b/Source/modules/webaudio/AudioContext.h
@@ -85,7 +85,7 @@ public:
virtual void trace(Visitor*) OVERRIDE;
- bool isInitialized() const;
+ bool isInitialized() const { return m_isInitialized; }
bool isOfflineContext() { return m_isOfflineContext; }
// Document notification
@@ -170,9 +170,6 @@ public:
ThreadIdentifier audioThread() const { return m_audioThread; }
bool isAudioThread() const;
- // Returns true only after the audio thread has been started and then shutdown.
- bool isAudioThreadFinished() { return m_isAudioThreadFinished; }
-
// mustReleaseLock is set to true if we acquired the lock in this method call and caller must unlock(), false if it was previously acquired.
void lock(bool& mustReleaseLock);
@@ -238,8 +235,6 @@ protected:
static bool isSampleRateRangeGood(float sampleRate);
private:
- void constructCommon();
-
void initialize();
void uninitialize();
@@ -255,7 +250,6 @@ private:
// Set to true when the destination node has been initialized and is ready to process data.
bool m_isInitialized;
- bool m_isAudioThreadFinished;
// The context itself keeps a reference to all source nodes. The source nodes, then reference all nodes they're connected to.
// In turn, these nodes reference all nodes they're connected to. All nodes are ultimately connected to the AudioDestinationNode.
« no previous file with comments | « no previous file | Source/modules/webaudio/AudioContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698