Don't mutate the DOM from inside an Element's constructor

Don't mutate the DOM from inside an Element's constructor

We shouldn't call ensureUserAgentShadowRoot() from inside an element's
constructor since not all constructors in the inheritance chain may
have run, and also since it means going into DOM methods that may want
to ref |this| before it's ever been adopted.

This patch fixes this and also fixes the RefPtr protects inside
notifyNodeInserted.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175077

[Hajime Morrita, 2014-05-29 01:42:32]

On 2014/05/29 01:12:17, esprehn wrote:

lgtm.

[Hajime Morrita, 2014-05-29 01:42:36]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-05-29 01:43:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/esprehn@chromium.org/304003002/1

[commit-bot: I haz the power, 2014-05-29 03:35:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9573)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/13398)

[commit-bot: I haz the power, 2014-05-29 04:17:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 04:17:36]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/13436)

[esprehn, 2014-05-29 05:51:12]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-05-29 05:51:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/esprehn@chromium.org/304003002/1

[esprehn, 2014-05-29 07:05:26]

The CQ bit was unchecked by esprehn@chromium.org

[esprehn, 2014-05-29 07:10:53]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-05-29 07:11:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/esprehn@chromium.org/304003002/20001

[commit-bot: I haz the power, 2014-05-30 00:30:53]

Change committed as 175077