Source/core/dom/ContainerNode.cpp - Issue 304003002: Don't mutate the DOM from inside an Element's constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ContainerNode.cpp

Issue 304003002: Don't mutate the DOM from inside an Element's constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix includes Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/ContainerNode.cpp

diff --git a/Source/core/dom/ContainerNode.cpp b/Source/core/dom/ContainerNode.cpp

index 2505987c1717cc407bd1e1d5b070b9769f7c87af..1fc7c062329e46aa4feb42bd357caa83c64ace83 100644

--- a/Source/core/dom/ContainerNode.cpp

+++ b/Source/core/dom/ContainerNode.cpp

@@ -665,7 +665,7 @@ void ContainerNode::notifyNodeInserted(Node& root)

InspectorInstrumentation::didInsertDOMNode(&root);

- RefPtr<Node> protectDocument(root.document());

+ RefPtr<Node> protect(this);

RefPtr<Node> protectNode(root);

NodeVector postInsertionNotificationTargets;

« no previous file with comments | « no previous file | Source/core/html/HTMLAudioElement.cpp » ('j') | no next file with comments »