Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: Source/core/dom/ContainerNode.cpp

Issue 304003002: Don't mutate the DOM from inside an Element's constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix includes Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/html/HTMLAudioElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 647 matching lines...) Expand 10 before | Expand all | Expand 10 after
658 childrenChanged(true, last, 0, 1); 658 childrenChanged(true, last, 0, 1);
659 notifyNodeInserted(*newChild); 659 notifyNodeInserted(*newChild);
660 } 660 }
661 661
662 void ContainerNode::notifyNodeInserted(Node& root) 662 void ContainerNode::notifyNodeInserted(Node& root)
663 { 663 {
664 ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden()); 664 ASSERT(!NoEventDispatchAssertion::isEventDispatchForbidden());
665 665
666 InspectorInstrumentation::didInsertDOMNode(&root); 666 InspectorInstrumentation::didInsertDOMNode(&root);
667 667
668 RefPtr<Node> protectDocument(root.document()); 668 RefPtr<Node> protect(this);
669 RefPtr<Node> protectNode(root); 669 RefPtr<Node> protectNode(root);
670 670
671 NodeVector postInsertionNotificationTargets; 671 NodeVector postInsertionNotificationTargets;
672 notifyNodeInsertedInternal(root, postInsertionNotificationTargets); 672 notifyNodeInsertedInternal(root, postInsertionNotificationTargets);
673 673
674 for (size_t i = 0; i < postInsertionNotificationTargets.size(); ++i) { 674 for (size_t i = 0; i < postInsertionNotificationTargets.size(); ++i) {
675 Node* targetNode = postInsertionNotificationTargets[i].get(); 675 Node* targetNode = postInsertionNotificationTargets[i].get();
676 if (targetNode->inDocument()) 676 if (targetNode->inDocument())
677 targetNode->didNotifySubtreeInsertionsToDocument(); 677 targetNode->didNotifySubtreeInsertionsToDocument();
678 } 678 }
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
1278 return true; 1278 return true;
1279 1279
1280 if (node->isElementNode() && toElement(node)->shadow()) 1280 if (node->isElementNode() && toElement(node)->shadow())
1281 return true; 1281 return true;
1282 1282
1283 return false; 1283 return false;
1284 } 1284 }
1285 #endif 1285 #endif
1286 1286
1287 } // namespace WebCore 1287 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/HTMLAudioElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698