Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: trunk/src/build/config/compiler/BUILD.gn

Issue 303493006: Revert 271207 "Changed android toolchain to use GCC 4.8" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/build/config/arm.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/build/config/compiler/BUILD.gn
===================================================================
--- trunk/src/build/config/compiler/BUILD.gn (revision 273187)
+++ trunk/src/build/config/compiler/BUILD.gn (working copy)
@@ -219,19 +219,8 @@
"-fno-short-enums",
]
if (!is_clang) {
- # Clang doesn't support these flags.
- cflags += [
- "-finline-limit=64",
- # The following 6 options are disabled to save on
- # binary size in gcc 4.8.
- # TODO(fdegans) Reevaluate when we upgrade GCC.
- "-fno-partial-inlining",
- "-fno-early-inlining",
- "-fno-tree-copy-prop",
- "-fno-tree-loop-optimize",
- "-fno-move-loop-invariants",
- "-fno-caller-saves",
- ]
+ # Clang doesn't support this one.
+ cflags += [ "-finline-limit=64" ]
}
if (is_android_webview_build) {
# Android predefines this as 1; undefine it here so Chromium can redefine
@@ -629,15 +618,6 @@
"-Wno-sign-promo",
]
}
-
- if (gcc_version >= 48) {
- # Don't warn about the "typedef 'foo' locally defined but not used"
- # for gcc 4.8.
- # TODO: remove this flag once all builds work. See crbug.com/227506
- cflags += [
- "-Wno-unused-local-typedefs",
- ]
- }
}
}
@@ -796,3 +776,4 @@
cflags = [ "-g0" ]
}
}
+
« no previous file with comments | « trunk/src/build/config/arm.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698