Issue 303163004: Revert 273819 "Re-enable PDFExtensionTest.BasicPlugin"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303163004: Revert 273819 "Re-enable PDFExtensionTest.BasicPlugin" (Closed)

Created:
6 years, 6 months ago by battre

Modified:
6 years, 6 months ago

Reviewers:
raymes

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 273819 "Re-enable PDFExtensionTest.BasicPlugin" Revert due to test failure. See http://crbug.com/303491#c97 for details. > Re-enable PDFExtensionTest.BasicPlugin > > This test was disabled because it was failing. A few changes have been made: > -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption. > -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091. > -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory). > > BUG=303491 > > Review URL: https://codereview.chromium.org/290803007 TBR=raymes@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273828

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -116 lines)			Patch
D	trunk/src/chrome/browser/resources/pdf/pdf_extension_test.cc	View	1 chunk	+0 lines, -94 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests.gypi	View	2 chunks	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/test/data/pdf/basic_plugin_test.js	View	2 chunks	+10 lines, -18 lines	0 comments	Download
A +	trunk/src/chrome/test/data/pdf/pdf_extension_test.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/test/data/pdf/viewport_test.js	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

battre

6 years, 6 months ago (2014-05-30 14:57:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r273828 (tree was closed).

Expand Messages | Collapse Messages