Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: trunk/src/chrome/test/data/pdf/basic_plugin_test.js

Issue 303163004: Revert 273819 "Re-enable PDFExtensionTest.BasicPlugin" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/chrome_tests.gypi ('k') | trunk/src/chrome/test/data/pdf/pdf_extension_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/test/data/pdf/basic_plugin_test.js
===================================================================
--- trunk/src/chrome/test/data/pdf/basic_plugin_test.js (revision 273827)
+++ trunk/src/chrome/test/data/pdf/basic_plugin_test.js (working copy)
@@ -10,10 +10,9 @@
* Test that the page is sized to the size of the document.
*/
function testPageSize() {
- // Verify that the initial zoom is less than or equal to 100%.
- chrome.test.assertTrue(viewer.viewport.zoom <= 1);
+ // Verify that the initial zoom is 100%.
+ chrome.test.assertEq(1, viewer.viewport.zoom);
- viewer.viewport.zoom = 1;
var sizer = document.getElementById('sizer');
chrome.test.assertEq(826, sizer.offsetWidth);
chrome.test.assertEq(1066, sizer.offsetHeight);
@@ -36,21 +35,14 @@
var dict = JSON.parse(json);
chrome.test.assertEq(612, dict.width);
chrome.test.assertEq(792, dict.height);
- if (dict.textBox[0] && dict.textBox[1]) {
- chrome.test.assertEq(1.0, dict.textBox[0].fontSize);
- chrome.test.assertEq('text', dict.textBox[0].textNodes[0].type);
- chrome.test.assertEq('this is some text',
- dict.textBox[0].textNodes[0].text);
- chrome.test.assertEq(1.0, dict.textBox[1].fontSize);
- chrome.test.assertEq('text', dict.textBox[1].textNodes[0].type);
- chrome.test.assertEq('some more text',
- dict.textBox[1].textNodes[0].text);
- } else {
- // TODO(raymes): Investigate the flakiness that's occuring with
- // returning accessibility information in this test: crbug.com/378091.
- console.error(
- 'Expected text boxes of accessibility data to be returned');
- }
+ chrome.test.assertEq(1.0, dict.textBox[0].fontSize);
+ chrome.test.assertEq('text', dict.textBox[0].textNodes[0].type);
+ chrome.test.assertEq('this is some text',
+ dict.textBox[0].textNodes[0].text);
+ chrome.test.assertEq(1.0, dict.textBox[1].fontSize);
+ chrome.test.assertEq('text', dict.textBox[1].textNodes[0].type);
+ chrome.test.assertEq('some more text',
+ dict.textBox[1].textNodes[0].text);
}), 0);
}
];
« no previous file with comments | « trunk/src/chrome/chrome_tests.gypi ('k') | trunk/src/chrome/test/data/pdf/pdf_extension_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698