Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 290803007: Re-enable PDFExtensionTest.BasicPlugin (Closed)

Created:
6 years, 7 months ago by raymes
Modified:
6 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Re-enable PDFExtensionTest.BasicPlugin This test was disabled because it was failing. A few changes have been made: -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption. -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091. -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory). BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278340

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : for test only #

Patch Set 8 : for test only #

Patch Set 9 : for test only #

Patch Set 10 : for test only #

Patch Set 11 : #

Patch Set 12 : for test only #

Patch Set 13 : for test only #

Patch Set 14 : for test only #

Patch Set 15 : for test only #

Patch Set 16 : for test only #

Patch Set 17 : #

Patch Set 18 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -115 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 2 3 4 5 8 9 2 chunks +3 lines, -0 lines 0 comments Download
A + chrome/browser/resources/pdf/pdf_extension_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +10 lines, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +1 line, -1 line 0 comments Download
D chrome/test/data/pdf/basic_plugin_test.js View 1 2 3 4 5 6 7 8 9 3 chunks +13 lines, -6 lines 0 comments Download
D chrome/test/data/pdf/pdf_extension_test.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/test/data/pdf/viewport_test.js View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M pdf/out_of_process_instance.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
raymes
6 years, 6 months ago (2014-05-28 01:01:05 UTC) #1
jam
lgtm with comment: the C++ browser test file is not in chrome/test/data, so the move ...
6 years, 6 months ago (2014-05-28 17:45:36 UTC) #2
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 6 months ago (2014-05-30 08:24:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/290803007/60001
6 years, 6 months ago (2014-05-30 08:26:28 UTC) #4
commit-bot: I haz the power
Change committed as 273819
6 years, 6 months ago (2014-05-30 13:18:44 UTC) #5
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 6 months ago (2014-06-02 04:18:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/290803007/80001
6 years, 6 months ago (2014-06-02 04:18:29 UTC) #7
commit-bot: I haz the power
Change committed as 274186
6 years, 6 months ago (2014-06-02 08:15:53 UTC) #8
raymes
for test only
6 years, 6 months ago (2014-06-04 04:25:31 UTC) #9
raymes
for test only
6 years, 6 months ago (2014-06-04 05:58:56 UTC) #10
raymes
for test only
6 years, 6 months ago (2014-06-05 01:51:41 UTC) #11
raymes
for test only
6 years, 6 months ago (2014-06-05 07:11:57 UTC) #12
raymes
for test only
6 years, 6 months ago (2014-06-06 05:01:29 UTC) #13
raymes
for test only
6 years, 6 months ago (2014-06-10 04:14:40 UTC) #14
raymes
for test only
6 years, 6 months ago (2014-06-11 00:31:05 UTC) #15
raymes
for test only
6 years, 6 months ago (2014-06-13 01:22:20 UTC) #16
raymes
for test only
6 years, 6 months ago (2014-06-13 01:35:13 UTC) #17
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 6 months ago (2014-06-18 08:18:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/290803007/320001
6 years, 6 months ago (2014-06-18 08:19:53 UTC) #19
commit-bot: I haz the power
Change committed as 278043
6 years, 6 months ago (2014-06-18 12:58:27 UTC) #20
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 6 months ago (2014-06-19 01:44:06 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/290803007/340001
6 years, 6 months ago (2014-06-19 01:45:26 UTC) #22
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 12:08:13 UTC) #23
Message was sent while issue was closed.
Change committed as 278340

Powered by Google App Engine
This is Rietveld 408576698