SVG: remove |SVGAnimateElement::m_animatedPropertyType|

SVG: remove |SVGAnimateElement::m_animatedPropertyType|

Before this patch, |SVGAnimateElement::m_animatedPropertyType|
was maintained along |SVGAnimatedTypeAnimator::m_type|,
and there were many ASSERTs checking that they were same.

In this patch, I removed
|SVGAnimateElement::m_animatedPropertyType| and changed
their references to point to
|SVGAnimatedTypeAnimator::m_type| instead.

BUG=378670
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175245

[kouhei (in TOK), 2014-05-29 07:27:17]

PTAL.

[pdr., 2014-05-29 21:38:00]

LGTM with nits.

Could you please wrap your change description to 72 or 80 columns?

https://codereview.chromium.org/303093002/diff/30001/Source/core/svg/SVGAnima...
File Source/core/svg/SVGAnimationElement.cpp (right):

https://codereview.chromium.org/303093002/diff/30001/Source/core/svg/SVGAnima...
Source/core/svg/SVGAnimationElement.cpp:504: calcMode = CalcModeDiscrete;
This looks like it could lead to a change in behavior. Could you add the
following asserts here?
ASSERT(animatedPropertyType() != AnimatedTransformList ||
isSVGAnimateTransformElement(*this));
ASSERT(animatedPropertyType() != AnimatedUnknown);

[kouhei (in TOK), 2014-05-30 01:15:23]

> Could you please wrap your change description to 72 or 80 columns?
Done.

https://codereview.chromium.org/303093002/diff/30001/Source/core/svg/SVGAnima...
File Source/core/svg/SVGAnimationElement.cpp (right):

https://codereview.chromium.org/303093002/diff/30001/Source/core/svg/SVGAnima...
Source/core/svg/SVGAnimationElement.cpp:504: calcMode = CalcModeDiscrete;
On 2014/05/29 21:38:00, pdr wrote:
> This looks like it could lead to a change in behavior. Could you add the
> following asserts here?
> ASSERT(animatedPropertyType() != AnimatedTransformList ||
> isSVGAnimateTransformElement(*this));
> ASSERT(animatedPropertyType() != AnimatedUnknown);

Done.

[kouhei (in TOK), 2014-05-30 01:15:55]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-05-30 01:17:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/303093002/90001

[Paweł Hajdan Jr., 2014-05-30 16:23:44]

The CQ bit was unchecked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2014-05-30 16:28:58]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-05-30 16:30:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/303093002/90001

[commit-bot: I haz the power, 2014-05-30 17:09:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-05-30 20:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 20:34:55]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[pdr., 2014-05-30 20:45:20]

On 2014/05/30 20:34:55, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_dbg on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

I believe this failure is real:
svg/animations/dynamic-modify-attributename-crash.svg

[kouhei (in TOK), 2014-06-02 01:02:43]

On 2014/05/30 20:45:20, pdr wrote:
> On 2014/05/30 20:34:55, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   linux_blink_dbg on tryserver.blink
> >
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
> 
> I believe this failure is real:
> svg/animations/dynamic-modify-attributename-crash.svg

Thanks! Fixed.

[kouhei (in TOK), 2014-06-02 01:02:47]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-06-02 01:02:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/303093002/130001

[commit-bot: I haz the power, 2014-06-02 02:13:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9775)

[commit-bot: I haz the power, 2014-06-02 02:48:33]

Change committed as 175245