Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Side by Side Diff: Source/core/svg/SVGAnimateTransformElement.cpp

Issue 303093002: SVG: remove |SVGAnimateElement::m_animatedPropertyType| (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: s/<animatedTransform>/<animateTransform> Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAnimateElement.cpp ('k') | Source/core/svg/SVGAnimatedTypeAnimator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 27 matching lines...) Expand all
38 38
39 bool SVGAnimateTransformElement::hasValidAttributeType() 39 bool SVGAnimateTransformElement::hasValidAttributeType()
40 { 40 {
41 SVGElement* targetElement = this->targetElement(); 41 SVGElement* targetElement = this->targetElement();
42 if (!targetElement) 42 if (!targetElement)
43 return false; 43 return false;
44 44
45 if (attributeType() == AttributeTypeCSS) 45 if (attributeType() == AttributeTypeCSS)
46 return false; 46 return false;
47 47
48 return m_animatedPropertyType == AnimatedTransformList; 48 return animatedPropertyType() == AnimatedTransformList;
49 } 49 }
50 50
51 bool SVGAnimateTransformElement::isSupportedAttribute(const QualifiedName& attrN ame) 51 bool SVGAnimateTransformElement::isSupportedAttribute(const QualifiedName& attrN ame)
52 { 52 {
53 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ()); 53 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
54 if (supportedAttributes.isEmpty()) 54 if (supportedAttributes.isEmpty())
55 supportedAttributes.add(SVGNames::typeAttr); 55 supportedAttributes.add(SVGNames::typeAttr);
56 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName); 56 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
57 } 57 }
58 58
59 void SVGAnimateTransformElement::parseAttribute(const QualifiedName& name, const AtomicString& value) 59 void SVGAnimateTransformElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
60 { 60 {
61 if (!isSupportedAttribute(name)) { 61 if (!isSupportedAttribute(name)) {
62 SVGAnimateElement::parseAttribute(name, value); 62 SVGAnimateElement::parseAttribute(name, value);
63 return; 63 return;
64 } 64 }
65 65
66 if (name == SVGNames::typeAttr) { 66 if (name == SVGNames::typeAttr) {
67 m_type = parseTransformType(value); 67 m_type = parseTransformType(value);
68 if (m_type == SVG_TRANSFORM_MATRIX) 68 if (m_type == SVG_TRANSFORM_MATRIX)
69 m_type = SVG_TRANSFORM_UNKNOWN; 69 m_type = SVG_TRANSFORM_UNKNOWN;
70 return; 70 return;
71 } 71 }
72 72
73 ASSERT_NOT_REACHED(); 73 ASSERT_NOT_REACHED();
74 } 74 }
75 75
76 } 76 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAnimateElement.cpp ('k') | Source/core/svg/SVGAnimatedTypeAnimator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698