Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 302893004: Remove V8TestingScope::create (Closed)

Created:
6 years, 6 months ago by haraken
Modified:
6 years, 6 months ago
Reviewers:
dcarney, adamk
CC:
blink-reviews, shans, arv+blink, dgrogan, Mike Lawther (Google), blink-reviews-animation_chromium.org, alecflett, jsbell+idb_chromium.org, abarth-chromium, dstockwell, Timothy Loh, blink-reviews-bindings_chromium.org, ericu+idb_chromium.org, cmumford, darktears, rjwright, Steve Block, Eric Willigers
Visibility:
Public.

Description

Remove V8TestingScope::create V8TestingScope is a "scope" object, so it's not a good idea to allow people to create V8TestingScope on heap. This CL forbids it. V8TestingScope should be used on stack or as a part of object. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -35 lines) Patch
M Source/bindings/v8/IDBBindingUtilitiesTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseResolverTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/EffectInputTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/TimingInputTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBRequestTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBTransactionTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
haraken
PTAL
6 years, 6 months ago (2014-05-29 02:35:24 UTC) #1
adamk
lgtm
6 years, 6 months ago (2014-05-29 17:58:26 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-05-29 23:17:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/302893004/1
6 years, 6 months ago (2014-05-29 23:18:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 06:07:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 06:47:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9534)
6 years, 6 months ago (2014-05-30 06:47:07 UTC) #7
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-05-30 06:50:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/302893004/1
6 years, 6 months ago (2014-05-30 06:52:19 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 07:31:37 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 08:09:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9550)
6 years, 6 months ago (2014-05-30 08:09:43 UTC) #12
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-05-30 08:37:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/302893004/1
6 years, 6 months ago (2014-05-30 08:38:37 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 08:40:01 UTC) #15
Message was sent while issue was closed.
Change committed as 175112

Powered by Google App Engine
This is Rietveld 408576698