Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: Source/core/animation/AnimationTest.cpp

Issue 302893004: Remove V8TestingScope::create (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/V8Binding.cpp ('k') | Source/core/animation/EffectInputTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/animation/Animation.h" 6 #include "core/animation/Animation.h"
7 7
8 #include "bindings/v8/Dictionary.h" 8 #include "bindings/v8/Dictionary.h"
9 #include "core/animation/AnimationClock.h" 9 #include "core/animation/AnimationClock.h"
10 #include "core/animation/AnimationHelpers.h" 10 #include "core/animation/AnimationHelpers.h"
(...skipping 19 matching lines...) Expand all
30 30
31 RefPtr<Document> document; 31 RefPtr<Document> document;
32 RefPtrWillBePersistent<Element> element; 32 RefPtrWillBePersistent<Element> element;
33 TrackExceptionState exceptionState; 33 TrackExceptionState exceptionState;
34 }; 34 };
35 35
36 class AnimationAnimationV8Test : public AnimationAnimationTest { 36 class AnimationAnimationV8Test : public AnimationAnimationTest {
37 protected: 37 protected:
38 AnimationAnimationV8Test() 38 AnimationAnimationV8Test()
39 : m_isolate(v8::Isolate::GetCurrent()) 39 : m_isolate(v8::Isolate::GetCurrent())
40 , m_scope(V8TestingScope::create(m_isolate)) 40 , m_scope(m_isolate)
41 { 41 {
42 } 42 }
43 43
44 template<typename T> 44 template<typename T>
45 static PassRefPtrWillBeRawPtr<Animation> createAnimation(Element* element, V ector<Dictionary> keyframeDictionaryVector, T timingInput, ExceptionState& excep tionState) 45 static PassRefPtrWillBeRawPtr<Animation> createAnimation(Element* element, V ector<Dictionary> keyframeDictionaryVector, T timingInput, ExceptionState& excep tionState)
46 { 46 {
47 return Animation::create(element, EffectInput::convert(element, keyframe DictionaryVector, exceptionState, true), timingInput); 47 return Animation::create(element, EffectInput::convert(element, keyframe DictionaryVector, exceptionState, true), timingInput);
48 } 48 }
49 static PassRefPtrWillBeRawPtr<Animation> createAnimation(Element* element, V ector<Dictionary> keyframeDictionaryVector, ExceptionState& exceptionState) 49 static PassRefPtrWillBeRawPtr<Animation> createAnimation(Element* element, V ector<Dictionary> keyframeDictionaryVector, ExceptionState& exceptionState)
50 { 50 {
51 return Animation::create(element, EffectInput::convert(element, keyframe DictionaryVector, exceptionState, true)); 51 return Animation::create(element, EffectInput::convert(element, keyframe DictionaryVector, exceptionState, true));
52 } 52 }
53 53
54 v8::Isolate* m_isolate; 54 v8::Isolate* m_isolate;
55 55
56 private: 56 private:
57 OwnPtr<V8TestingScope> m_scope; 57 V8TestingScope m_scope;
58 }; 58 };
59 59
60 TEST_F(AnimationAnimationV8Test, CanCreateAnAnimation) 60 TEST_F(AnimationAnimationV8Test, CanCreateAnAnimation)
61 { 61 {
62 Vector<Dictionary> jsKeyframes; 62 Vector<Dictionary> jsKeyframes;
63 v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate); 63 v8::Handle<v8::Object> keyframe1 = v8::Object::New(m_isolate);
64 v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate); 64 v8::Handle<v8::Object> keyframe2 = v8::Object::New(m_isolate);
65 65
66 setV8ObjectPropertyAsString(keyframe1, "width", "100px"); 66 setV8ObjectPropertyAsString(keyframe1, "width", "100px");
67 setV8ObjectPropertyAsString(keyframe1, "offset", "0"); 67 setV8ObjectPropertyAsString(keyframe1, "offset", "0");
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 EXPECT_EQ(element.get(), animation->target()); 457 EXPECT_EQ(element.get(), animation->target());
458 document->timeline().play(animation.get()); 458 document->timeline().play(animation.get());
459 document.clear(); 459 document.clear();
460 element.clear(); 460 element.clear();
461 #if !ENABLE(OILPAN) 461 #if !ENABLE(OILPAN)
462 EXPECT_EQ(0, animation->target()); 462 EXPECT_EQ(0, animation->target());
463 #endif 463 #endif
464 } 464 }
465 465
466 } // namespace WebCore 466 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8Binding.cpp ('k') | Source/core/animation/EffectInputTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698