Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: Source/core/animation/TimingInputTest.cpp

Issue 302893004: Remove V8TestingScope::create (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/animation/EffectInputTest.cpp ('k') | Source/modules/indexeddb/IDBRequestTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/animation/TimingInput.h" 6 #include "core/animation/TimingInput.h"
7 7
8 #include "bindings/v8/Dictionary.h" 8 #include "bindings/v8/Dictionary.h"
9 #include "core/animation/AnimationNodeTiming.h" 9 #include "core/animation/AnimationNodeTiming.h"
10 #include "core/animation/AnimationTestHelper.h" 10 #include "core/animation/AnimationTestHelper.h"
11 11
12 #include <gtest/gtest.h> 12 #include <gtest/gtest.h>
13 13
14 namespace WebCore { 14 namespace WebCore {
15 15
16 class AnimationTimingInputTest : public ::testing::Test { 16 class AnimationTimingInputTest : public ::testing::Test {
17 protected: 17 protected:
18 AnimationTimingInputTest() 18 AnimationTimingInputTest()
19 : m_isolate(v8::Isolate::GetCurrent()) 19 : m_isolate(v8::Isolate::GetCurrent())
20 , m_scope(V8TestingScope::create(m_isolate)) 20 , m_scope(m_isolate)
21 { 21 {
22 } 22 }
23 23
24 Timing applyTimingInputNumber(String timingProperty, double timingPropertyVa lue) 24 Timing applyTimingInputNumber(String timingProperty, double timingPropertyVa lue)
25 { 25 {
26 v8::Handle<v8::Object> timingInput = v8::Object::New(m_isolate); 26 v8::Handle<v8::Object> timingInput = v8::Object::New(m_isolate);
27 setV8ObjectPropertyAsNumber(timingInput, timingProperty, timingPropertyV alue); 27 setV8ObjectPropertyAsNumber(timingInput, timingProperty, timingPropertyV alue);
28 Dictionary timingInputDictionary = Dictionary(v8::Handle<v8::Value>::Cas t(timingInput), m_isolate); 28 Dictionary timingInputDictionary = Dictionary(v8::Handle<v8::Value>::Cas t(timingInput), m_isolate);
29 return TimingInput::convert(timingInputDictionary); 29 return TimingInput::convert(timingInputDictionary);
30 } 30 }
31 31
32 Timing applyTimingInputString(String timingProperty, String timingPropertyVa lue) 32 Timing applyTimingInputString(String timingProperty, String timingPropertyVa lue)
33 { 33 {
34 v8::Handle<v8::Object> timingInput = v8::Object::New(m_isolate); 34 v8::Handle<v8::Object> timingInput = v8::Object::New(m_isolate);
35 setV8ObjectPropertyAsString(timingInput, timingProperty, timingPropertyV alue); 35 setV8ObjectPropertyAsString(timingInput, timingProperty, timingPropertyV alue);
36 Dictionary timingInputDictionary = Dictionary(v8::Handle<v8::Value>::Cas t(timingInput), m_isolate); 36 Dictionary timingInputDictionary = Dictionary(v8::Handle<v8::Value>::Cas t(timingInput), m_isolate);
37 return TimingInput::convert(timingInputDictionary); 37 return TimingInput::convert(timingInputDictionary);
38 } 38 }
39 39
40 v8::Isolate* m_isolate; 40 v8::Isolate* m_isolate;
41 41
42 private: 42 private:
43 OwnPtr<V8TestingScope> m_scope; 43 V8TestingScope m_scope;
44 }; 44 };
45 45
46 TEST_F(AnimationTimingInputTest, TimingInputStartDelay) 46 TEST_F(AnimationTimingInputTest, TimingInputStartDelay)
47 { 47 {
48 EXPECT_EQ(1.1, applyTimingInputNumber("delay", 1100).startDelay); 48 EXPECT_EQ(1.1, applyTimingInputNumber("delay", 1100).startDelay);
49 EXPECT_EQ(-1, applyTimingInputNumber("delay", -1000).startDelay); 49 EXPECT_EQ(-1, applyTimingInputNumber("delay", -1000).startDelay);
50 EXPECT_EQ(1, applyTimingInputString("delay", "1000").startDelay); 50 EXPECT_EQ(1, applyTimingInputString("delay", "1000").startDelay);
51 EXPECT_EQ(0, applyTimingInputString("delay", "1s").startDelay); 51 EXPECT_EQ(0, applyTimingInputString("delay", "1s").startDelay);
52 EXPECT_EQ(0, applyTimingInputString("delay", "Infinity").startDelay); 52 EXPECT_EQ(0, applyTimingInputString("delay", "Infinity").startDelay);
53 EXPECT_EQ(0, applyTimingInputString("delay", "-Infinity").startDelay); 53 EXPECT_EQ(0, applyTimingInputString("delay", "-Infinity").startDelay);
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 EXPECT_EQ(controlTiming.fillMode, updatedTiming.fillMode); 172 EXPECT_EQ(controlTiming.fillMode, updatedTiming.fillMode);
173 EXPECT_EQ(controlTiming.iterationStart, updatedTiming.iterationStart); 173 EXPECT_EQ(controlTiming.iterationStart, updatedTiming.iterationStart);
174 EXPECT_EQ(controlTiming.iterationCount, updatedTiming.iterationCount); 174 EXPECT_EQ(controlTiming.iterationCount, updatedTiming.iterationCount);
175 EXPECT_TRUE(std::isnan(updatedTiming.iterationDuration)); 175 EXPECT_TRUE(std::isnan(updatedTiming.iterationDuration));
176 EXPECT_EQ(controlTiming.playbackRate, updatedTiming.playbackRate); 176 EXPECT_EQ(controlTiming.playbackRate, updatedTiming.playbackRate);
177 EXPECT_EQ(controlTiming.direction, updatedTiming.direction); 177 EXPECT_EQ(controlTiming.direction, updatedTiming.direction);
178 EXPECT_EQ(*controlTiming.timingFunction, *updatedTiming.timingFunction); 178 EXPECT_EQ(*controlTiming.timingFunction, *updatedTiming.timingFunction);
179 } 179 }
180 180
181 } // namespace WebCore 181 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/animation/EffectInputTest.cpp ('k') | Source/modules/indexeddb/IDBRequestTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698