Incremental refactoring of GrGLProgram and GrGLShaderBuilder

Incremental refactoring of GrGLProgram and GrGLShaderBuilder

Committed: http://code.google.com/p/skia/source/detail?r=14980

[bsalomon, 2014-05-28 20:45:17]

Next piece of refactoring. The main things here are calling the builder before
creating the program object and removing a bunch of stuff from the builder's
public section.

I'm thinking that your idea of having the output struct in the program makes
sense but I had already started on this. It probably makes sense for the builder
to have one too.

[robertphillips, 2014-05-29 12:24:57]

lgtm + very minor nits

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLProgram.c...
src/gpu/gl/GrGLProgram.cpp:40: const GrGLShaderBuilder::GenProgramOutput&
builderOutput)
ident the initializer list?

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLShaderBui...
File src/gpu/gl/GrGLShaderBuilder.h (right):

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLShaderBui...
src/gpu/gl/GrGLShaderBuilder.h:237: void
createAndEmitEffects(GrGLProgramEffectsBuilder*,
extra spaces here?

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLUniformMa...
File src/gpu/gl/GrGLUniformManager.h (right):

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLUniformMa...
src/gpu/gl/GrGLUniformManager.h:115: GrGpuGL* fGpu;
INHERITED ?

[bsalomon, 2014-05-29 21:20:45]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-05-29 21:21:35]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/302663006/60001

[bsalomon, 2014-05-29 21:22:16]

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLProgram.c...
src/gpu/gl/GrGLProgram.cpp:40: const GrGLShaderBuilder::GenProgramOutput&
builderOutput)
On 2014/05/29 12:24:57, robertphillips wrote:
> ident the initializer list?

Done.

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLShaderBui...
File src/gpu/gl/GrGLShaderBuilder.h (right):

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLShaderBui...
src/gpu/gl/GrGLShaderBuilder.h:237: void
createAndEmitEffects(GrGLProgramEffectsBuilder*,
On 2014/05/29 12:24:57, robertphillips wrote:
> extra spaces here?

Done.

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLUniformMa...
File src/gpu/gl/GrGLUniformManager.h (right):

https://codereview.chromium.org/302663006/diff/20001/src/gpu/gl/GrGLUniformMa...
src/gpu/gl/GrGLUniformManager.h:115: GrGpuGL* fGpu;
On 2014/05/29 12:24:57, robertphillips wrote:
> INHERITED ?

Done.

[commit-bot: I haz the power, 2014-05-29 21:29:54]

Change committed as 14980