content/public/renderer/render_view_observer.cc - Issue 302553007: Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/render_view_observer.cc

Issue 302553007: Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add and remove observer inside SetRenderView(). Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/renderer/render_view_observer.h ('K') | « content/public/renderer/render_view_observer.h ('k') | content/renderer/renderer_webkitplatformsupport_impl.h » ('j') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/renderer/render_view_observer.cc

diff --git a/content/public/renderer/render_view_observer.cc b/content/public/renderer/render_view_observer.cc

index 612fb150234d6ce79d81ab207e9eb65b4f199807..be51166485b354bf7571ff3a9c25862fa5bc0b1d 100644

--- a/content/public/renderer/render_view_observer.cc

+++ b/content/public/renderer/render_view_observer.cc

@@ -53,4 +53,15 @@ void RenderViewObserver::RenderViewGone() {

render_view_ = NULL;

}

+void RenderViewObserver::SetRenderView(RenderView* render_view) {

jochen (gone - plz use gerrit) 2014/06/03 12:52:25 in WebContentsObserver, we call this method Observ

ostap 2014/06/03 15:32:32 Done.

+ RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view_);

+ if (impl)

+ impl->RemoveObserver(this);

+ render_view_ = render_view;

+ impl = static_cast<RenderViewImpl*>(render_view_);

+ if (impl)

+ impl->AddObserver(this);

} // namespace content