content/renderer/renderer_webkitplatformsupport_impl.h - Issue 302553007: Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_webkitplatformsupport_impl.h

Issue 302553007: Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add and remove observer inside SetRenderView(). Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/renderer/render_view_observer.cc ('K') | « content/public/renderer/render_view_observer.cc ('k') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('j') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/renderer_webkitplatformsupport_impl.h

diff --git a/content/renderer/renderer_webkitplatformsupport_impl.h b/content/renderer/renderer_webkitplatformsupport_impl.h

index a91ffefbc9767d2f999f2906bd104a0a17007a07..5301cb12d699b2700a7476c09287294ac8b3a67b 100644

--- a/content/renderer/renderer_webkitplatformsupport_impl.h

+++ b/content/renderer/renderer_webkitplatformsupport_impl.h

@@ -40,6 +40,7 @@ class DeviceMotionEventPump;

class DeviceOrientationEventPump;

class QuotaMessageFilter;

class RendererClipboardClient;

+class RenderView;

class ScreenOrientationDispatcher;

class ThreadSafeSender;

class WebClipboardImpl;

@@ -181,6 +182,7 @@ class CONTENT_EXPORT RendererWebKitPlatformSupportImpl

const blink::WebDeviceOrientationData& data);

// Forces the screen orientation for testing purposes.

static void SetMockScreenOrientationForTesting(

+ RenderView* render_view,

blink::WebScreenOrientationType);

// Resets the mock screen orientation data used for testing.

static void ResetMockScreenOrientationForTesting();