Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie…

content/public/renderer/render_view_observer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/renderer/render_view_observer.h"
 
 #include "content/renderer/render_view_impl.h"
 
 using blink::WebFrame;
 
 namespace content {
 
 RenderViewObserver::RenderViewObserver(RenderView* render_view)
     : render_view_(render_view),
       routing_id_(MSG_ROUTING_NONE) {
   // |render_view| can be NULL on unit testing.

[jochen (gone - plz use gerrit), 2014/06/03 12:52:25]

please update this comment

[ostap, 2014/06/03 15:32:32]

Done.

   if (render_view) {
     RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view);
     routing_id_ = impl->routing_id();
     // TODO(jam): bring this back DCHECK_NE(routing_id_, MSG_ROUTING_NONE);
     impl->AddObserver(this);
   }
 }
 
 RenderViewObserver::~RenderViewObserver() {
   if (render_view_) {
@@ skipping 19 matching lines @@
 }
 
 RenderView* RenderViewObserver::render_view() const {
   return render_view_;
 }
 
 void RenderViewObserver::RenderViewGone() {
   render_view_ = NULL;
 }
 
+void RenderViewObserver::SetRenderView(RenderView* render_view) {

[jochen (gone - plz use gerrit), 2014/06/03 12:52:25]

in WebContentsObserver, we call this method Observe()

[ostap, 2014/06/03 15:32:32]

Done.

+  RenderViewImpl* impl = static_cast<RenderViewImpl*>(render_view_);
+  if (impl)
+    impl->RemoveObserver(this);
+
+  render_view_ = render_view;
+  impl = static_cast<RenderViewImpl*>(render_view_);
+  if (impl)
+    impl->AddObserver(this);
+}
+
 }  // namespace content