Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 3020453002: Dashboard - Add more logging around Sheriffs and alert creation. (Closed)

Created:
3 years, 3 months ago by shatch
Modified:
3 years, 2 months ago
Reviewers:
sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Dashboard - Add more logging around Sheriffs and alert creation. We log every change from /edit_site_config but nothing from /edit_sheriffs, so sending to same group. Also added a bit more logging during alert creation. BUG=catapult:#3903 Review-Url: https://chromiumcodereview.appspot.com/3020453002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9a255f51046c55ea3c209acd64e36d8a5bd46fa4

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -1 line) Patch
M dashboard/dashboard/edit_config_handler.py View 1 3 chunks +46 lines, -0 lines 0 comments Download
M dashboard/dashboard/edit_sheriffs_test.py View 1 1 chunk +35 lines, -0 lines 0 comments Download
M dashboard/dashboard/find_anomalies.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 24 (20 generated)
shatch
3 years, 3 months ago (2017-09-22 21:10:25 UTC) #7
sullivan
lgtm
3 years, 2 months ago (2017-09-25 15:37:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3020453002/80001
3 years, 2 months ago (2017-09-25 15:39:16 UTC) #21
commit-bot: I haz the power
3 years, 2 months ago (2017-09-25 16:11:01 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698