Dashboard - Add more logging around Sheriffs and alert creation.

dashboard/dashboard/edit_config_handler.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A common base class for pages that are used to edit configs."""
 
+import json
+
+from google.appengine.api import app_identity
+from google.appengine.api import mail
 from google.appengine.api import taskqueue
+from google.appengine.api import users
 
 from dashboard import list_tests
 from dashboard.common import request_handler
 from dashboard.common import utils
 from dashboard.common import xsrf
 
 # Max number of entities to put in one request to /put_entities_task.
 _MAX_TESTS_TO_PUT_AT_ONCE = 25
 
 # The queue to use to re-put tests. Should be present in queue.yaml.
 _TASK_QUEUE_NAME = 'edit-sheriffs-queue'
 
 # Minimum time before starting tasks, in seconds. It appears that the tasks
 # may be executed before the sheriff is saved, so this is a workaround for that.
 # See http://crbug.com/621499
 _TASK_QUEUE_COUNTDOWN = 60
 
+_NOTIFICATION_EMAIL_BODY = """
+The configuration of %(hostname)s was changed by %(user)s.
+
+Key: %(key)s
+
+Added test paths:
+%(added_test_paths)s
+
+Removed test paths:
+%(removed_test_paths)s
+"""
+
+# TODO(qyearsley): Make this customizable by storing the value in datastore.
+# Make sure to send a notification to both old and new address if this value
+# gets changed.
+_NOTIFICATION_ADDRESS = 'chrome-performance-monitoring-alerts@google.com'
+_SENDER_ADDRESS = 'gasper-alerts@google.com'
+
 
 class EditConfigHandler(request_handler.RequestHandler):
   """Base class for handlers that are used to add or edit entities.
 
   Specifically, this is a common base class for EditSheriffsHandler
   and EditAnomalyConfigsHandler. Both of these kinds of entities
   represent a configuration that can apply to a set of tests, where
   the set of tests is specified with a list of test path patterns.
   """
 
@@ skipping 62 matching lines @@
   def _UpdateAndReportResults(self, entity):
     """Updates the entity and reports the results of this updating."""
     new_patterns = _SplitPatternLines(self.request.get('patterns'))
     old_patterns = entity.patterns
     entity.patterns = new_patterns
     self._UpdateFromRequestParameters(entity)
     entity.put()
     added_test_paths, removed_test_paths = _ChangeTestPatterns(
         old_patterns, new_patterns)
     self._RenderResults(entity, added_test_paths, removed_test_paths)
+    self._SendNotificationEmail(entity, added_test_paths, removed_test_paths)
+
+  def _SendNotificationEmail(
+      self, entity, added_test_paths, removed_test_paths):
+    user_email = users.get_current_user().email()
+    subject = 'Added or updated %s: %s by %s' % (
+        self._model_class.__name__, entity.key.string_id(), user_email)
+    email_body = _NOTIFICATION_EMAIL_BODY % {
+        'key': entity.key.string_id(),
+        'added_test_paths': json.dumps(
+            list(added_test_paths), indent=2, sort_keys=True,
+            separators=(',', ': ')),
+        'removed_test_paths': json.dumps(
+            list(removed_test_paths), indent=2, sort_keys=True,
+            separators=(',', ': ')),
+        'hostname': app_identity.get_default_version_hostname(),
+        'user': user_email,
+    }
+    mail.send_mail(
+        sender=_SENDER_ADDRESS,
+        to=_NOTIFICATION_ADDRESS,
+        subject=subject,
+        body=email_body)
 
   def _UpdateFromRequestParameters(self, entity):
     """Updates the given entity based on query parameters.
 
     This method does not need to put() the entity.
 
     Args:
       entity: The entity to update.
     """
     raise NotImplementedError()
@@ skipping 110 matching lines @@
     test_paths: List of test paths of tests to be re-put.
   """
   for start_index in range(0, len(test_paths), _MAX_TESTS_TO_PUT_AT_ONCE):
     group = test_paths[start_index:start_index + _MAX_TESTS_TO_PUT_AT_ONCE]
     urlsafe_keys = [utils.TestKey(t).urlsafe() for t in group]
     taskqueue.add(
         url='/put_entities_task',
         params={'keys': ','.join(urlsafe_keys)},
         queue_name=_TASK_QUEUE_NAME,
         countdown=_TASK_QUEUE_COUNTDOWN)