Make Inspector aware of RemoteFrames in FrameTree

Make Inspector aware of RemoteFrames in FrameTree

We will soon make FrameTree operate on the Frame base class, which can
be instantiated as either LocalFrame or RemoteFrame. This patch modifies
the call sites in the Inspector that will be affected by this change.

BUG=346764
TBR=pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175303

[kenrb, 2014-05-29 19:55:41]

Vsevolod: it looks like Pavel is out of office. Are you able to review this
patch?

We don't know how to make devtools work with out of process iframes, but
initially we are just making the inspector ignore them. This is necessary to get
the code infrastructure into Blink for RemoteFrame.

[kenrb, 2014-05-30 16:34:57]

eustas@, are you able to review this change?

[pfeldman, 2014-05-30 17:38:11]

+yurys

[yurys, 2014-06-02 07:56:26]

lgtm

https://codereview.chromium.org/301983003/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorCanvasAgent.cpp (right):

https://codereview.chromium.org/301983003/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorCanvasAgent.cpp:321: if
(m_framesWithUninstrumentedCanvases.contains(toLocalFrame(frame)))
Please extract toLocalFrame(frame) into a variable.

https://codereview.chromium.org/301983003/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/301983003/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorPageAgent.cpp:881: if (frame->tree().parent() &&
frame->tree().parent()->isLocalFrame())
Please extract frame->tree().parent() into a variable for better readability.

https://codereview.chromium.org/301983003/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorPageAgent.cpp:1089: if (frame->tree().parent() &&
frame->tree().parent()->isLocalFrame())
Ditto.

https://codereview.chromium.org/301983003/diff/20001/Source/modules/filesyste...
File Source/modules/filesystem/InspectorFileSystemAgent.cpp (right):

https://codereview.chromium.org/301983003/diff/20001/Source/modules/filesyste...
Source/modules/filesystem/InspectorFileSystemAgent.cpp:718: if
(frame->isLocalFrame() && toLocalFrame(frame)->document() &&
toLocalFrame(frame)->document()->securityOrigin()->isSameSchemeHostPort(origin))
LocalFrame* localFrame = toLocalFrame(frame); ...

[kenrb, 2014-06-02 15:20:47]

Thanks for the review.

Looks like I still need pfeldman's to review and/or rubber stamp for the
Source/modules change.

https://codereview.chromium.org/301983003/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorCanvasAgent.cpp (right):

https://codereview.chromium.org/301983003/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorCanvasAgent.cpp:321: if
(m_framesWithUninstrumentedCanvases.contains(toLocalFrame(frame)))
On 2014/06/02 07:56:27, yurys wrote:
> Please extract toLocalFrame(frame) into a variable.

Done.

https://codereview.chromium.org/301983003/diff/20001/Source/core/inspector/In...
File Source/core/inspector/InspectorPageAgent.cpp (right):

https://codereview.chromium.org/301983003/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorPageAgent.cpp:881: if (frame->tree().parent() &&
frame->tree().parent()->isLocalFrame())
On 2014/06/02 07:56:27, yurys wrote:
> Please extract frame->tree().parent() into a variable for better readability.

Done.

https://codereview.chromium.org/301983003/diff/20001/Source/core/inspector/In...
Source/core/inspector/InspectorPageAgent.cpp:1089: if (frame->tree().parent() &&
frame->tree().parent()->isLocalFrame())
On 2014/06/02 07:56:27, yurys wrote:
> Ditto.

Done.

https://codereview.chromium.org/301983003/diff/20001/Source/modules/filesyste...
File Source/modules/filesystem/InspectorFileSystemAgent.cpp (right):

https://codereview.chromium.org/301983003/diff/20001/Source/modules/filesyste...
Source/modules/filesystem/InspectorFileSystemAgent.cpp:718: if
(frame->isLocalFrame() && toLocalFrame(frame)->document() &&
toLocalFrame(frame)->document()->securityOrigin()->isSameSchemeHostPort(origin))
On 2014/06/02 07:56:27, yurys wrote:
> LocalFrame* localFrame = toLocalFrame(frame); ...

Done.

[yurys, 2014-06-02 15:34:53]

On 2014/06/02 15:20:47, kenrb wrote:
> Thanks for the review.
> 
> Looks like I still need pfeldman's to review and/or rubber stamp for the
> Source/modules change.
> 
He is on vacation for the next 2 weeks. You can put him in TBR.

[kenrb, 2014-06-02 16:23:03]

The CQ bit was checked by kenrb@chromium.org

[commit-bot: I haz the power, 2014-06-02 16:23:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kenrb@chromium.org/301983003/40001

[commit-bot: I haz the power, 2014-06-02 17:05:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9879)

[commit-bot: I haz the power, 2014-06-02 17:55:38]

Change committed as 175303