Source/core/inspector/InspectorDOMAgent.cpp - Issue 301983003: Make Inspector aware of RemoteFrames in FrameTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 301983003: Make Inspector aware of RemoteFrames in FrameTree (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: yurys' review comment addressed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp

index fbe6ed5797eeb0fea71238d912c6b95cfba2cb91..fb5d021905d762e3667c63936ef9a1cebe6cafae 100644

--- a/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/Source/core/inspector/InspectorDOMAgent.cpp

@@ -282,8 +282,10 @@ void InspectorDOMAgent::restore()

Vector<Document*> InspectorDOMAgent::documents()

{

Vector<Document*> result;

- for (LocalFrame* frame = m_document->frame(); frame; frame = frame->tree().traverseNext()) {

- Document* document = frame->document();

+ for (Frame* frame = m_document->frame(); frame; frame = frame->tree().traverseNext()) {

+ if (!frame->isLocalFrame())

+ continue;

+ Document* document = toLocalFrame(frame)->document();

if (!document)

continue;

result.append(document);