Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: Source/core/inspector/InspectorApplicationCacheAgent.cpp

Issue 301983003: Make Inspector aware of RemoteFrames in FrameTree (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: yurys' review comment addressed Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/inspector/InspectorCanvasAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorApplicationCacheAgent.cpp
diff --git a/Source/core/inspector/InspectorApplicationCacheAgent.cpp b/Source/core/inspector/InspectorApplicationCacheAgent.cpp
index 8994242d56711d6eeaaff49ea9c97b9868b213b1..6d8804cb23cfe3078325129f49c536f35eb27494 100644
--- a/Source/core/inspector/InspectorApplicationCacheAgent.cpp
+++ b/Source/core/inspector/InspectorApplicationCacheAgent.cpp
@@ -100,8 +100,10 @@ void InspectorApplicationCacheAgent::getFramesWithManifests(ErrorString*, RefPtr
result = TypeBuilder::Array<TypeBuilder::ApplicationCache::FrameWithManifest>::create();
LocalFrame* mainFrame = m_pageAgent->mainFrame();
- for (LocalFrame* frame = mainFrame; frame; frame = frame->tree().traverseNext(mainFrame)) {
- DocumentLoader* documentLoader = frame->loader().documentLoader();
+ for (Frame* frame = mainFrame; frame; frame = frame->tree().traverseNext(mainFrame)) {
+ if (!frame->isLocalFrame())
+ continue;
+ DocumentLoader* documentLoader = toLocalFrame(frame)->loader().documentLoader();
if (!documentLoader)
continue;
@@ -110,7 +112,7 @@ void InspectorApplicationCacheAgent::getFramesWithManifests(ErrorString*, RefPtr
String manifestURL = info.m_manifest.string();
if (!manifestURL.isEmpty()) {
RefPtr<TypeBuilder::ApplicationCache::FrameWithManifest> value = TypeBuilder::ApplicationCache::FrameWithManifest::create()
- .setFrameId(m_pageAgent->frameId(frame))
+ .setFrameId(m_pageAgent->frameId(toLocalFrame(frame)))
.setManifestURL(manifestURL)
.setStatus(static_cast<int>(host->status()));
result->addItem(value);
« no previous file with comments | « no previous file | Source/core/inspector/InspectorCanvasAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698