components/nacl/loader/nacl_listener.cc - Issue 301973003: Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_listener.cc

Issue 301973003: Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing mac build Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nacl_listener.cc

diff --git a/components/nacl/loader/nacl_listener.cc b/components/nacl/loader/nacl_listener.cc

index 5056f0f70e986d08e2d45396fb77acd210c744e2..5f1966d861b5056f6778ff6fa6593a32d9aa86fa 100644

--- a/components/nacl/loader/nacl_listener.cc

+++ b/components/nacl/loader/nacl_listener.cc

@@ -244,11 +244,11 @@ void NaClListener::Listen() {

std::string channel_name =

CommandLine::ForCurrentProcess()->GetSwitchValueASCII(

switches::kProcessChannelID);

- channel_.reset(new IPC::SyncChannel(

- this, io_thread_.message_loop_proxy().get(), &shutdown_event_));

+ channel_ = IPC::SyncChannel::Create(

+ this, io_thread_.message_loop_proxy().get(), &shutdown_event_);

filter_ = new IPC::SyncMessageFilter(&shutdown_event_);

channel_->AddFilter(filter_.get());

- channel_->Init(channel_name, IPC::Channel::MODE_CLIENT, true);

+ channel_->InitClient(channel_name, true);

main_loop_ = base::MessageLoop::current();

main_loop_->Run();

}