Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: ipc/ipc_channel_proxy.h

Issue 301973003: Introduce IPC::ChannelProxy::Create*() and IPC::SynChannel::Create*() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing mac build Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/gpu_channel.cc ('k') | ipc/ipc_channel_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_proxy.h
diff --git a/ipc/ipc_channel_proxy.h b/ipc/ipc_channel_proxy.h
index 0a3a5d2fb05b480d356c8a66e731045295f554ba..d1f270dd5b18c97a61dea48d2ec1ab130eb4ec21 100644
--- a/ipc/ipc_channel_proxy.h
+++ b/ipc/ipc_channel_proxy.h
@@ -64,10 +64,31 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
// on the background thread. Any message not handled by the filter will be
// dispatched to the listener. The given task runner correspond to a thread
// on which IPC::Channel is created and used (e.g. IO thread).
- ChannelProxy(const IPC::ChannelHandle& channel_handle,
- Channel::Mode mode,
- Listener* listener,
- base::SingleThreadTaskRunner* ipc_task_runner);
+ // The naming pattern follows IPC::Channel. The Create() does not create
+ // underlying channel and let Init*() do it.
+ static scoped_ptr<ChannelProxy> Create(
+ Listener* listener,
+ base::SingleThreadTaskRunner* ipc_task_runner);
+
+ static scoped_ptr<ChannelProxy> CreateClient(
+ const IPC::ChannelHandle& channel_handle,
+ Listener* listener,
+ base::SingleThreadTaskRunner* ipc_task_runner);
+
+ static scoped_ptr<ChannelProxy> CreateServer(
+ const IPC::ChannelHandle& channel_handle,
+ Listener* listener,
+ base::SingleThreadTaskRunner* ipc_task_runner);
+
+ static scoped_ptr<ChannelProxy> CreateNamedClient(
+ const IPC::ChannelHandle& channel_handle,
+ Listener* listener,
+ base::SingleThreadTaskRunner* ipc_task_runner);
+
+ static scoped_ptr<ChannelProxy> CreateNamedServer(
+ const IPC::ChannelHandle& channel_handle,
+ Listener* listener,
+ base::SingleThreadTaskRunner* ipc_task_runner);
virtual ~ChannelProxy();
@@ -75,8 +96,17 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
// proxy that was not initialized in its constructor. If create_pipe_now is
// true, the pipe is created synchronously. Otherwise it's created on the IO
// thread.
- void Init(const IPC::ChannelHandle& channel_handle, Channel::Mode mode,
- bool create_pipe_now);
+ // The naming pattern follows IPC::Channel::Create*().
+ void InitByMode(const IPC::ChannelHandle& channel_handle, Channel::Mode mode,
+ bool create_pipe_now);
+ void InitClient(const IPC::ChannelHandle& channel_handle,
+ bool create_pipe_now);
+ void InitServer(const IPC::ChannelHandle& channel_handle,
+ bool create_pipe_now);
+ void InitNamedClient(const IPC::ChannelHandle& channel_handle,
+ bool create_pipe_now);
+ void InitNamedServer(const IPC::ChannelHandle& channel_handle,
+ bool create_pipe_now);
// Close the IPC::Channel. This operation completes asynchronously, once the
// background thread processes the command to close the channel. It is ok to
@@ -124,6 +154,10 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
// to the internal state.
ChannelProxy(Context* context);
+ ChannelProxy(Listener* listener,
+ base::SingleThreadTaskRunner* ipc_task_runner);
+
+
// Used internally to hold state that is referenced on the IPC thread.
class Context : public base::RefCountedThreadSafe<Context>,
public Listener {
« no previous file with comments | « content/common/gpu/gpu_channel.cc ('k') | ipc/ipc_channel_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698