Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Issue 3019513002: Remove the VoiceEngineObserver callback interface. (Closed)

Created:
3 years, 3 months ago by the sun
Modified:
3 years, 2 months ago
Reviewers:
ossu, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the VoiceEngineObserver callback interface. BUG=webrtc:4690 TBR=kwiberg@webrtc.org Review-Url: https://codereview.webrtc.org/3019513002 Cr-Commit-Position: refs/heads/master@{#19976} Committed: https://webrtc.googlesource.com/src/+/fc3a2e33933ac3f982133f282abf1418c6a27aa1

Patch Set 1 #

Patch Set 2 : fix tests #

Patch Set 3 : ios build #

Patch Set 4 : rebase + build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -385 lines) Patch
M audio/audio_receive_stream_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M audio/audio_send_stream_unittest.cc View 1 4 chunks +4 lines, -24 lines 0 comments Download
M audio/audio_state.h View 3 chunks +1 line, -10 lines 0 comments Download
M audio/audio_state.cc View 1 5 chunks +6 lines, -23 lines 0 comments Download
M audio/audio_state_unittest.cc View 1 2 chunks +0 lines, -26 lines 0 comments Download
M media/engine/fakewebrtcvoiceengine.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/mock_voice_engine.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M voice_engine/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M voice_engine/channel.h View 4 chunks +0 lines, -5 lines 0 comments Download
M voice_engine/channel.cc View 4 chunks +0 lines, -33 lines 0 comments Download
M voice_engine/include/voe_base.h View 1 2 chunks +0 lines, -20 lines 0 comments Download
M voice_engine/include/voe_errors.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
D voice_engine/monitor_module.h View 1 chunk +0 lines, -40 lines 0 comments Download
M voice_engine/shared_data.cc View 1 chunk +1 line, -2 lines 0 comments Download
M voice_engine/transmit_mixer.h View 1 2 4 chunks +10 lines, -28 lines 0 comments Download
M voice_engine/transmit_mixer.cc View 4 chunks +15 lines, -101 lines 0 comments Download
M voice_engine/voe_base_impl.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M voice_engine/voe_base_impl.cc View 1 2 3 4 chunks +2 lines, -57 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
the sun
3 years, 3 months ago (2017-09-23 07:03:28 UTC) #2
ossu
What an interesting solution. Nice to see it go since it isn't used. lgtm
3 years, 2 months ago (2017-09-26 15:41:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3019513002/60001
3 years, 2 months ago (2017-09-26 16:06:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/22022)
3 years, 2 months ago (2017-09-26 16:11:57 UTC) #7
the sun
On 2017/09/26 16:11:57, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 2 months ago (2017-09-26 16:31:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3019513002/60001
3 years, 2 months ago (2017-09-26 16:32:26 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://webrtc.googlesource.com/src/+/fc3a2e33933ac3f982133f282abf1418c6a27aa1
3 years, 2 months ago (2017-09-26 16:35:07 UTC) #15
kwiberg-webrtc
3 years, 2 months ago (2017-09-27 07:52:49 UTC) #16
Message was sent while issue was closed.
lgtm for test/mock_voice_engine.h

Powered by Google App Engine
This is Rietveld 408576698