Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: voice_engine/include/voe_base.h

Issue 3019513002: Remove the VoiceEngineObserver callback interface. (Closed)
Patch Set: rebase + build error Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « voice_engine/channel.cc ('k') | voice_engine/include/voe_errors.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: voice_engine/include/voe_base.h
diff --git a/voice_engine/include/voe_base.h b/voice_engine/include/voe_base.h
index b2daca19cdb53bf2331364ce6b35e4688e694aa1..94ac6ac461de059d0b53ffc01d9fc1e34cb32780 100644
--- a/voice_engine/include/voe_base.h
+++ b/voice_engine/include/voe_base.h
@@ -48,18 +48,6 @@ namespace voe {
class TransmitMixer;
} // namespace voe
-// VoiceEngineObserver
-class WEBRTC_DLLEXPORT VoiceEngineObserver {
- public:
- // This method will be called after the occurrence of any runtime error
- // code, or warning notification, when the observer interface has been
- // installed using VoEBase::RegisterVoiceEngineObserver().
- virtual void CallbackOnError(int channel, int errCode) = 0;
-
- protected:
- virtual ~VoiceEngineObserver() {}
-};
-
// VoiceEngine
class WEBRTC_DLLEXPORT VoiceEngine {
public:
@@ -96,14 +84,6 @@ class WEBRTC_DLLEXPORT VoEBase {
// for all sub-APIs before the VoiceEngine object can be safely deleted.
virtual int Release() = 0;
- // Installs the observer class to enable runtime error control and
- // warning notifications. Returns -1 in case of an error, 0 otherwise.
- virtual int RegisterVoiceEngineObserver(VoiceEngineObserver& observer) = 0;
-
- // Removes and disables the observer class for runtime error control
- // and warning notifications. Returns 0.
- virtual int DeRegisterVoiceEngineObserver() = 0;
-
// Initializes all common parts of the VoiceEngine; e.g. all
// encoders/decoders, the sound card and core receiving components.
// This method also makes it possible to install some user-defined external
« no previous file with comments | « voice_engine/channel.cc ('k') | voice_engine/include/voe_errors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698