Fix uses of /deep/ in trace viewer.

Fix uses of /deep/ in trace viewer.

There are several old modules that use tr.ui.b.define() and /deep/ CSS rules.
Support for /deep/ is being removed from Chrome in M63, which will branch in a few
weeks.
This CL moves all of the /deep/ CSS rules into javascript.
This is not the best way to solve this problem.
The best way to solve this problem would be to turn all of these old modules into
proper Polymer dom-modules: https://github.com/catapult-project/catapult/issues/3058
However, that will be tricky and take time that would be better spent on other
things. This CL is a stop-gap.

ListAndAssociatedView appears entirely unused, so it is removed.

http://www/~benjhayden/3017523002.html

BUG=catapult:#1691,chromium:765447

[benjhayden, 2017-09-15 17:05:24]

Description was changed from

==========
Fix uses of /deep/.

BUG=catapult:#1691
==========

to

==========
Fix uses of /deep/ in trace viewer.

TODO
add back css
http://localhost:8003/tracing_examples/trace_viewer.html#/tracing/test_data/t...
verify that all /deep/ rules are stricken in devtools

BUG=catapult:#1691
==========

[benjhayden, 2017-09-15 17:05:41]

Description was changed from

==========
Fix uses of /deep/ in trace viewer.

TODO
add back css
http://localhost:8003/tracing_examples/trace_viewer.html#/tracing/test_data/t...
verify that all /deep/ rules are stricken in devtools

BUG=catapult:#1691
==========

to

==========
Fix uses of /deep/ in trace viewer.

TODO
add back css
http://localhost:8003/tracing_examples/trace_viewer.html#/tracing/test_data/t...
verify that all /deep/ rules are stricken in devtools

BUG=catapult:#1691,chromium:765447
==========

[benjhayden, 2017-09-15 22:07:09]

Description was changed from

==========
Fix uses of /deep/ in trace viewer.

TODO
add back css
http://localhost:8003/tracing_examples/trace_viewer.html#/tracing/test_data/t...
verify that all /deep/ rules are stricken in devtools

BUG=catapult:#1691,chromium:765447
==========

to

==========
Fix uses of /deep/ in trace viewer.

BUG=catapult:#1691,chromium:765447
==========

[benjhayden, 2017-09-15 22:07:17]

Patchset #1 (id:1) has been deleted

[benjhayden, 2017-09-15 22:07:20]

Patchset #1 (id:20001) has been deleted

[benjhayden, 2017-09-15 22:17:57]

Patchset #1 (id:40001) has been deleted

[benjhayden, 2017-09-15 22:18:01]

Patchset #1 (id:40001) has been deleted

[benjhayden, 2017-09-15 22:18:05]

Patchset #1 (id:60001) has been deleted

[benjhayden, 2017-09-15 22:18:09]

Patchset #1 (id:80001) has been deleted

[benjhayden, 2017-09-16 04:45:50]

Patchset #1 (id:100001) has been deleted

[benjhayden, 2017-09-16 04:45:55]

Patchset #1 (id:120001) has been deleted

[benjhayden, 2017-09-16 04:46:01]

Patchset #1 (id:140001) has been deleted

[benjhayden, 2017-09-16 04:52:02]

Description was changed from

==========
Fix uses of /deep/ in trace viewer.

BUG=catapult:#1691,chromium:765447
==========

to

==========
Fix uses of /deep/ in trace viewer.

There are several old modules that use tr.ui.b.define() and /deep/ CSS rules.
Support for /deep/ is being removed from Chrome in M63, which will branch in a
few
weeks.
This CL moves all of the /deep/ CSS rules into javascript.
This is not the best way to solve this problem.
The best way to solve this problem would be to turn all of these old modules
into
proper Polymer dom-modules:
https://github.com/catapult-project/catapult/issues/3058
However, that will be tricky and take time that would be better spent on other
things. This CL is a stop-gap.

BUG=catapult:#1691,chromium:765447
==========

[benjhayden, 2017-09-16 04:53:52]

Description was changed from

==========
Fix uses of /deep/ in trace viewer.

There are several old modules that use tr.ui.b.define() and /deep/ CSS rules.
Support for /deep/ is being removed from Chrome in M63, which will branch in a
few
weeks.
This CL moves all of the /deep/ CSS rules into javascript.
This is not the best way to solve this problem.
The best way to solve this problem would be to turn all of these old modules
into
proper Polymer dom-modules:
https://github.com/catapult-project/catapult/issues/3058
However, that will be tricky and take time that would be better spent on other
things. This CL is a stop-gap.

BUG=catapult:#1691,chromium:765447
==========

to

==========
Fix uses of /deep/ in trace viewer.

There are several old modules that use tr.ui.b.define() and /deep/ CSS rules.
Support for /deep/ is being removed from Chrome in M63, which will branch in a
few
weeks.
This CL moves all of the /deep/ CSS rules into javascript.
This is not the best way to solve this problem.
The best way to solve this problem would be to turn all of these old modules
into
proper Polymer dom-modules:
https://github.com/catapult-project/catapult/issues/3058
However, that will be tricky and take time that would be better spent on other
things. This CL is a stop-gap.

ListAndAssociatedView appears entirely unused, so it is removed.

BUG=catapult:#1691,chromium:765447
==========

[benjhayden, 2017-09-16 04:56:08]

benjhayden@chromium.org changed reviewers:
+ fmeawad@chromium.org, vmpstr@chromium.org

[benjhayden, 2017-09-17 05:27:07]

Description was changed from

==========
Fix uses of /deep/ in trace viewer.

There are several old modules that use tr.ui.b.define() and /deep/ CSS rules.
Support for /deep/ is being removed from Chrome in M63, which will branch in a
few
weeks.
This CL moves all of the /deep/ CSS rules into javascript.
This is not the best way to solve this problem.
The best way to solve this problem would be to turn all of these old modules
into
proper Polymer dom-modules:
https://github.com/catapult-project/catapult/issues/3058
However, that will be tricky and take time that would be better spent on other
things. This CL is a stop-gap.

ListAndAssociatedView appears entirely unused, so it is removed.

BUG=catapult:#1691,chromium:765447
==========

to

==========
Fix uses of /deep/ in trace viewer.

There are several old modules that use tr.ui.b.define() and /deep/ CSS rules.
Support for /deep/ is being removed from Chrome in M63, which will branch in a
few
weeks.
This CL moves all of the /deep/ CSS rules into javascript.
This is not the best way to solve this problem.
The best way to solve this problem would be to turn all of these old modules
into
proper Polymer dom-modules:
https://github.com/catapult-project/catapult/issues/3058
However, that will be tricky and take time that would be better spent on other
things. This CL is a stop-gap.

ListAndAssociatedView appears entirely unused, so it is removed.

http://www/~benjhayden/3017523002.html

BUG=catapult:#1691,chromium:765447
==========

[benjhayden, 2017-09-25 04:45:39]

Friendly ping. :-)
This bug needs to be fixed before M63 branches on Oct 12.

[fmeawad, 2017-09-27 20:51:25]

lgtm

https://codereview.chromium.org/3017523002/diff/180001/tracing/tracing/ui/ext...
File tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html
(right):

https://codereview.chromium.org/3017523002/diff/180001/tracing/tracing/ui/ext...
tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html:197:
showAnimationBoundsCheckbox.style.verticalAlign = '-2px';
Can we move -2px into a const called VERTICAL_ALIGN_PX or something?

[benjhayden, 2017-09-27 21:26:15]

On 2017/09/27 at 20:51:25, fmeawad wrote:
> lgtm
> 
>
https://codereview.chromium.org/3017523002/diff/180001/tracing/tracing/ui/ext...
> File tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html
(right):
> 
>
https://codereview.chromium.org/3017523002/diff/180001/tracing/tracing/ui/ext...
> tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html:197:
showAnimationBoundsCheckbox.style.verticalAlign = '-2px';
> Can we move -2px into a const called VERTICAL_ALIGN_PX or something?

I tested it on linux and mac, both on the <span> and the <input>, and this -2px
doesn't appear to have any effect at all, so I removed it.
The spec says that vertical-align only takes effect in "dispay:inline" layout
contexts, but both  `this.controls_` and the <span> returned by createCheckbox()
are display:flex and have been for a while.
I updated the demo in the CL description.

Thanks!

[fmeawad, 2017-09-27 21:33:09]

Sounds good. Thanks!

[benjhayden, 2017-09-27 21:39:28]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2017-09-27 21:39:28]

The patchset sent to the CQ was uploaded after l-g-t-m from fmeawad@chromium.org
Link to the patchset: https://codereview.chromium.org/3017523002/#ps200001
(title: "remove verticalAlign: -2px")

[commit-bot: I haz the power, 2017-09-27 21:39:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-27 22:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-27 22:04:09]

Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

[benjhayden, 2017-09-28 17:04:23]

On 2017/09/27 at 22:04:09, commit-bot wrote:
> Try jobs failed on following builders:
>   Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

This was caught in the gerrit migration, so can you stamp it there?
https://chromium-review.googlesource.com/c/catapult/+/689742